Fix weight mapping test for Transfomers v5#33162
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Jan 27, 2026
Merged
Fix weight mapping test for Transfomers v5#33162DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively addresses compatibility issues with Transformers v5 by making the access to tie_word_embeddings more robust across the codebase. The use of getattr with a default value prevents potential AttributeError exceptions for models where this attribute might be missing. The temporary fix in the test utility create_dummy_model for tied weights on meta device is a pragmatic solution to ensure tests pass while awaiting an upstream fix. Overall, these changes improve the stability and resilience of the system against variations in model configurations.
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
DarkLight1337
approved these changes
Jan 27, 2026
github-actions
bot
added
the
ready
VedantMadane
pushed a commit
to VedantMadane/vllm
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
apd10
pushed a commit
to apd10/vllm
that referenced
this pull request
Jan 31, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metadevice huggingface/transformers#43522 is closed)tie_word_embeddingsto usegetattrfor robustness because it may not be defined for all models