Remove unused logic in models/mistral.py#33095
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Jan 26, 2026
Merged
Conversation
Signed-off-by: Andy Lo <andy@mistral.ai>
robertgshaw2-redhat
approved these changes
Jan 26, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
The pull request effectively removes unused logic related to quant_config and quantization scaling fusion within the MistralDecoderLayer's __init__ method. This cleanup improves code maintainability and reduces unnecessary complexity, aligning with the stated objective of the pull request. The super().__init__ call already handles the necessary quant_config initialization for attention and MLP layers, making the removed lines redundant.
github-actions
bot
added
the
ready
apd10
pushed a commit
to apd10/vllm
that referenced
this pull request
Jan 31, 2026
Signed-off-by: Andy Lo <andy@mistral.ai>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Andy Lo <andy@mistral.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some unused logic was added in #32780, cleaning it up.