[Bugfix] Fix Intern / Radio Pooling Tests#33044
Closed
alex-jw-brooks wants to merge 2 commits intovllm-project:mainfrom
Closed
[Bugfix] Fix Intern / Radio Pooling Tests#33044alex-jw-brooks wants to merge 2 commits intovllm-project:mainfrom
alex-jw-brooks wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a potential AttributeError in get_vit_attn_backend that could occur if vllm_config.model_config is None. The change to safely access multimodal_config is a good improvement.
I noticed that the same potential bug exists in the is_vit_use_data_parallel function within the same file (vllm/model_executor/models/vision.py). It also accesses vllm_config.model_config.multimodal_config without checking if vllm_config.model_config is None. I recommend applying a similar fix there to prevent future issues.
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
DarkLight1337
approved these changes
Jan 26, 2026
Member
DarkLight1337
left a comment
DarkLight1337
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Member
|
Oh, actually #33033 shuold fix this already |
Contributor
Author
|
Ah, didn't see it! I will close this one 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes test failures in #33028; here, we are creating the vision encoder components directly from their HF configs (or adapted pretrained config subclasses in vLLM) to test them in isolation. As a result, the vLLM Config is using the default fixture, which has
Nonefor the ModelConfig, and breaks when it tries to access the multimodal subconfig.Falls back to
Nonefor the multimodal config is there is noModelConfigon the retrieved vLLM Config for any reason.Test Plan
Intern / Radio tests should pass.
Test Result
Tests pass
CC @DarkLight1337 @robertgshaw2-redhat