[Voxtral] Streaming example#33042
Conversation
|
Documentation preview: https://vllm--33042.org.readthedocs.build/en/33042/ |
There was a problem hiding this comment.
Code Review
This pull request introduces a new example for real-time audio streaming with Voxtral. While it's a good starting point, there are a few critical issues that need addressing. The example contains unreachable code with a debugging trace, uses a hardcoded file path making it non-portable, and employs a forceful process cleanup method that is not robust. I've provided specific comments and suggestions to resolve these issues.
3649d17 to
c0a1518
Compare
|
Hi @patrickvonplaten, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
Hi @patrickvonplaten, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
|
Hi @patrickvonplaten, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
| """ | ||
| def __init__(self, tokenizer: MistralTokenizer) -> None: | ||
| # TODO(Patrick) - put these into the tokenizer config | ||
| self._look_ahead_in_ms = 2.5 |
There was a problem hiding this comment.
audio input takes care of look ahead and look back
|
Hi @patrickvonplaten, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
| model_name = "mistralai/Voxtral-Mini-3B-Realtime-2602" | ||
| tokenizer = MistralTokenizer.from_hf_hub(model_name) | ||
|
|
||
| @pytest.mark.skip(reason="Voxtral streaming is not yet public") |
There was a problem hiding this comment.
skip for now
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| @pytest.mark.skip(reason="Voxtral streaming is not yet public") |
There was a problem hiding this comment.
skip for now - important to make sure async generator works as expected
| # 'true' streaming and 'offline' streaming differ a bit because log-mels are | ||
| # differently noramalized | ||
| # TODO(Patrick) - check if we want to align or not | ||
| texts[0] = texts[0].replace("He has f", "F") |
There was a problem hiding this comment.
small diff because of log-mel
|
Hi @patrickvonplaten, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
…kvonplaten/vllm into voxstral_realtime_example
|
Hi @patrickvonplaten, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
mgoin
left a comment
There was a problem hiding this comment.
Looks reasonable to me, will see if the update breaks any tests
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Roger Wang <hey@rogerw.io>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Roger Wang <hey@rogerw.io> Signed-off-by: PiratePai <416932041@qq.com> Signed-off-by: Pai <416932041@qq.com>
Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com> Co-authored-by: Roger Wang <hey@rogerw.io>
This PR adds a test for the new streaming generator API: #28973 which works nicely!