Skip to content

[Bugfix][CI] Fix pre-commit#32956

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
MatthewBonanni:fix_import
Jan 23, 2026
Merged

[Bugfix][CI] Fix pre-commit#32956
vllm-bot merged 1 commit intovllm-project:mainfrom
MatthewBonanni:fix_import

Conversation

@MatthewBonanni
Copy link
Collaborator

@MatthewBonanni MatthewBonanni commented Jan 23, 2026

Purpose

Fixes pre-commit issue caused by #30877. The issue shouldn't break CI because check_triton_import only checks the diff, but it shows up when merging main into PR branches

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
@mergify mergify bot added v1 bug Something isn't working labels Jan 23, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug in the pre-commit configuration by correcting the import statement for tl and triton in vllm/v1/worker/mamba_utils.py. The original code had these imports directly from the triton package, which is now resolved by importing them from vllm.triton_utils. This change ensures that the pre-commit checks pass successfully. The review identifies that the original import statement is removed and the correct import is added.

I am having trouble creating individual review comments. Click here to see my feedback.

vllm/v1/worker/mamba_utils.py (7-8)

high

high: The direct import of triton and triton.language is removed, which is necessary to resolve the pre-commit issue. However, it's crucial to ensure that all functionalities previously relying on these direct imports are now correctly handled by the new import from vllm.triton_utils. Verify that no other part of the code in this file depends on the removed imports in a way that is not covered by the new import.

@vllm-bot vllm-bot merged commit 2d6b537 into vllm-project:main Jan 23, 2026
9 of 11 checks passed
@MatthewBonanni MatthewBonanni deleted the fix_import branch January 23, 2026 18:29
cwazai pushed a commit to cwazai/vllm that referenced this pull request Jan 25, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: 陈建华 <1647430658@qq.com>
lapy pushed a commit to lapy/vllm that referenced this pull request Jan 27, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants