[Bugfix][CI] Fix pre-commit#32956
Conversation
There was a problem hiding this comment.
Code Review
This pull request addresses a bug in the pre-commit configuration by correcting the import statement for tl and triton in vllm/v1/worker/mamba_utils.py. The original code had these imports directly from the triton package, which is now resolved by importing them from vllm.triton_utils. This change ensures that the pre-commit checks pass successfully. The review identifies that the original import statement is removed and the correct import is added.
I am having trouble creating individual review comments. Click here to see my feedback.
vllm/v1/worker/mamba_utils.py (7-8)
high: The direct import of triton and triton.language is removed, which is necessary to resolve the pre-commit issue. However, it's crucial to ensure that all functionalities previously relying on these direct imports are now correctly handled by the new import from vllm.triton_utils. Verify that no other part of the code in this file depends on the removed imports in a way that is not covered by the new import.
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com> Signed-off-by: 陈建华 <1647430658@qq.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Signed-off-by: Matthew Bonanni <mbonanni@redhat.com>
Purpose
Fixes pre-commit issue caused by #30877. The issue shouldn't break CI because
check_triton_importonly checks the diff, but it shows up when merging main into PR branchesTest Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.