[Hardware][AMD][CI][Bugfix] Fix Kernels Attention Cache test#32904
Merged
LucasWilkinson merged 1 commit intovllm-project:mainfrom Jan 23, 2026
Merged
[Hardware][AMD][CI][Bugfix] Fix Kernels Attention Cache test#32904LucasWilkinson merged 1 commit intovllm-project:mainfrom
LucasWilkinson merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
mawong-amd
requested review from
WoosukKwon,
mgoin,
tlrmchlsmth and
yewentao256
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request provides a targeted and correct fix for a failing test related to FP8 dequantization. By replacing the hardcoded torch.float8_e4m3fn with current_platform.fp8_dtype(), the test now correctly handles different FP8 formats across various hardware platforms, such as the e4m3fnuz format on certain AMD GPUs. The change is well-scoped and effectively resolves the bug described, improving the test suite's robustness.
LucasWilkinson
approved these changes
Jan 23, 2026
github-actions
bot
added
the
ready
yewentao256
approved these changes
Jan 23, 2026
Member
yewentao256
left a comment
yewentao256
left a comment
There was a problem hiding this comment.
LGTM, thanks for the work!
3 tasks
cwazai
pushed a commit
to cwazai/vllm
that referenced
this pull request
Jan 25, 2026
…oject#32904) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com> Signed-off-by: 陈建华 <1647430658@qq.com>
lapy
pushed a commit
to lapy/vllm
that referenced
this pull request
Jan 27, 2026
…oject#32904) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…oject#32904) Signed-off-by: Matthew Wong <Matthew.Wong2@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes a failing test (
kernels/attention/test_cache.py::test_reshape_and_cache_flash) caused by #30141. The reference dequantization implementation used in the test assumes the FP8 data format ise4m3fn, but on AMDgfx942-series cards, the FP8 data type used ise4m3fnuzinstead.Test Plan
Run
pytest -sv tests/kernels/attention/test_cache.py -k test_reshape_and_cache_flashon a MI325X as part of the Kernels Attention tests in AMD CI.
Test Result
The above test now passes.
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.