[Model Runner V2] Do not error on attention backends#32820
Merged
WoosukKwon merged 1 commit intomainfrom Jan 22, 2026
Merged
Conversation
Signed-off-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes a hardcoded check in GPUModelRunner that restricted the supported attention backends to FLASH_ATTN, FLASHINFER, and FLASHINFER_MLA. By deleting this validation, the model runner becomes more generic and can now accommodate other attention backends. This change is consistent with the removed TODO comment which indicated the need to support more backends. The modification is clean, correct, and improves the flexibility of the system. I approve this change.
njhill
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.