Skip to content

[ROCm][CI] fix get_valid_backends #32787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjtanaa merged 1 commit into from
Jan 22, 2026
Merged

[ROCm][CI] fix get_valid_backends #32787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/v1/spec_decode/test_acceptance_length.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,14 @@ class Eagle3ModelConfig:


def get_available_attention_backends() -> list[str]:
if not hasattr(current_platform, "get_valid_backends"):
return ["FLASH_ATTN"]
# Check if get_valid_backends is actually defined in the platform class
# (not just returning None from __getattr__)
get_valid_backends = getattr(current_platform.__class__, "get_valid_backends", None)
if get_valid_backends is None:
if current_platform.is_rocm():
return ["TRITON_ATTN"]
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why TRITON_ATTN is used here with a code comment?

Copy link
Copy Markdown
Collaborator

@AndreasKaratzas AndreasKaratzas Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DarkLight1337 Triton is AMD's default attention backend, and we are not compatible with the flash attn backend that is used for the CUDA equivalent tests. Let us know if you'd like us to put a comment there still.

Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the purpose of the comment is to tell other developers who are not as familiar with ROCm about this

else:
return ["FLASH_ATTN"]

device_capability = current_platform.get_device_capability()
if device_capability is None:
Expand Down
Loading