[CI]: remove unused FLASHINFER_AOT_COMPILE build argument#32627
Closed
haitwang-cloud wants to merge 1 commit into
Closed
[CI]: remove unused FLASHINFER_AOT_COMPILE build argument#32627haitwang-cloud wants to merge 1 commit into
haitwang-cloud wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused FLASHINFER_AOT_COMPILE build argument from the Buildkite pipeline for CUDA 12.9 release image builds. The change is correct, as my analysis of docker/Dockerfile confirms the argument is neither declared nor used. This cleanup improves the clarity and maintainability of the build configuration. The change is sound and I have no further comments.
The FLASHINFER_AOT_COMPILE build argument was being passed to docker build commands but was never declared or used in the Dockerfile. FlashInfer pre-compiled packages (flashinfer-cubin and flashinfer-jit-cache) are installed unconditionally in the vllm-base stage, making this argument ineffective. This commit removes the unused argument from CUDA 12.9 release image builds to reduce confusion in the build configuration. Signed-off-by: Tim <tim.wang03@sap.com>
haitwang-cloud
force-pushed
the
cleanup/remove-unused-flashinfer-aot-compile-arg
branch
from
4fd7d14 to
dc4699b
Compare
haitwang-cloud
changed the title
Contributor
|
This pull request has merge conflicts that must be resolved before it can be |
Harry-Chen
added a commit
to Harry-Chen/vllm
that referenced
this pull request
Apr 15, 2026
The FLASHINFER_AOT_COMPILE ARG was removed from the Dockerfile in PR vllm-project#32627, but stale references remained in the release pipeline and docker-bake.hcl. Clean them up. Signed-off-by: Shengqi Chen <harry-chen@outlook.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Remove the unused
FLASHINFER_AOT_COMPILEbuild argument from CUDA 12.9 release image builds in the Buildkite pipeline.The
FLASHINFER_AOT_COMPILE=truebuild argument was being passed to docker build commands but was never declared or used indocker/Dockerfile. FlashInfer pre-compiled packages (flashinfer-cubinandflashinfer-jit-cache) are installed unconditionally in thevllm-basestage, making this argument ineffective.This commit removes the dead code from:
Build release image - x86_64 - CUDA 12.9Build release image - aarch64 - CUDA 12.9Note: CUDA 13.0 release image builds already did not include this argument.
Test Plan
FLASHINFER_AOT_COMPILEis not declared as anARGindocker/Dockerfilevllm-basestageTest Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.