[BUGFIX] Fix degenerate strides in TRTLLM query tensors for FlashInfer backend. Fixes issue #32353#32417
Merged
pavanimajety merged 2 commits intovllm-project:mainfrom Jan 19, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the issue of degenerate strides in TRTLLM query tensors for the FlashInfer backend. The addition of .reshape(tensor.shape) after .contiguous() correctly forces non-degenerate strides, resolving the reported bug. The accompanying comments clearly explain the rationale behind this change, enhancing code clarity and maintainability.
mgoin
reviewed
Jan 15, 2026
Collaborator
Author
|
According to ci-health |
Collaborator
Author
|
previously failed test was workarounded in another commit. Now CI passed successfully |
pavanimajety
approved these changes
Jan 19, 2026
Collaborator
pavanimajety
left a comment
pavanimajety
left a comment
There was a problem hiding this comment.
Thanks for the fixes @vadiklyutiy
1 task
This was referenced Jan 20, 2026
gopalsarda
pushed a commit
to gopalsarda/vllm
that referenced
this pull request
Jan 20, 2026
…r backend. Fixes issue vllm-project#32353 (vllm-project#32417) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…r backend. Fixes issue vllm-project#32353 (vllm-project#32417) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
1 task
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…r backend. Fixes issue vllm-project#32353 (vllm-project#32417) Signed-off-by: Vadim Gimpelson <vadim.gimpelson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue #32353 with degenerate strides in query tensors when using the TRTLLM kernels in the FlashInfer attention backend. The
.contiguous()call alone doesn't fix degenerate strides when a dimension has size 1, which can cause issues with kernel execution.Problem
Query tensors can have degenerate strides and
.contiguous()doesn't fix it. In #32353:Test
starts successfully