Skip to content

[3/N] Group together media-related code - #32406

Merged
DarkLight1337 merged 1 commit into
vllm-project:mainfrom
DarkLight1337:mm-media
Jan 15, 2026
Merged

DarkLight1337 merged 1 commit into
vllm-project:mainfrom
DarkLight1337:mm-media

Conversation

@DarkLight1337

@DarkLight1337 DarkLight1337 commented Jan 15, 2026

Copy link
Copy Markdown
Member

Purpose

Improve code organization

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 15, 2026
@mergify mergify Bot added the multi-modality Related to multi-modality (#4194) label Jan 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a well-executed refactoring that improves code organization by grouping media-related code into a new vllm/multimodal/media package. The changes involve moving classes and functions for handling audio, image, and video from various files into this new, dedicated directory. Corresponding tests have also been relocated to a new tests/multimodal/media/ directory, maintaining a clean test structure. A notable improvement is the fix for a RecursionError that occurred when pickling MediaWithBytes objects, which is accompanied by a new regression test. Overall, these changes enhance modularity and maintainability without introducing any issues.

@Isotr0py
Isotr0py enabled auto-merge (squash) January 15, 2026 10:49
@DarkLight1337
DarkLight1337 enabled auto-merge (squash) January 15, 2026 10:49
@DarkLight1337
DarkLight1337 merged commit 2845978 into vllm-project:main Jan 15, 2026
55 of 56 checks passed
@DarkLight1337
DarkLight1337 deleted the mm-media branch January 15, 2026 11:52
sammysun0711 pushed a commit to sammysun0711/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
mystous pushed a commit to mystous/vllm_hybrid that referenced this pull request May 10, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
my-other-github-account pushed a commit to my-other-github-account/vllm that referenced this pull request May 15, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
0826joyce pushed a commit to 0826joyce/vllm-serving-optimization that referenced this pull request May 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
plasticchris pushed a commit to plasticchris/vllm that referenced this pull request Jul 20, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants