[3/N] Group together media-related code - #32406
Merged
Merged
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
requested review from
NickLucche,
aarnphm,
hmellor,
noooop,
robertgshaw2-redhat,
tjtanaa and
ywang96
as code owners
January 15, 2026 10:12
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a well-executed refactoring that improves code organization by grouping media-related code into a new vllm/multimodal/media package. The changes involve moving classes and functions for handling audio, image, and video from various files into this new, dedicated directory. Corresponding tests have also been relocated to a new tests/multimodal/media/ directory, maintaining a clean test structure. A notable improvement is the fix for a RecursionError that occurred when pickling MediaWithBytes objects, which is accompanied by a new regression test. Overall, these changes enhance modularity and maintainability without introducing any issues.
Isotr0py
approved these changes
Jan 15, 2026
Isotr0py
enabled auto-merge (squash)
January 15, 2026 10:49
DarkLight1337
disabled auto-merge
January 15, 2026 10:49
DarkLight1337
enabled auto-merge (squash)
January 15, 2026 10:49
sammysun0711
pushed a commit
to sammysun0711/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
5 tasks
mystous
pushed a commit
to mystous/vllm_hybrid
that referenced
this pull request
May 10, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
my-other-github-account
pushed a commit
to my-other-github-account/vllm
that referenced
this pull request
May 15, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
0826joyce
pushed a commit
to 0826joyce/vllm-serving-optimization
that referenced
this pull request
May 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
plasticchris
pushed a commit
to plasticchris/vllm
that referenced
this pull request
Jul 20, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Improve code organization
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.