[Docker] Remove CUDA compatibility library loading; fixes #32373#32377
[Docker] Remove CUDA compatibility library loading; fixes #32373#32377wangshangsam wants to merge 4 commits intovllm-project:mainfrom
Conversation
|
@huydhn there we go |
There was a problem hiding this comment.
Code Review
This pull request removes the CUDA compatibility library loading commands from the Dockerfile. The change is presented as a bug fix for an issue introduced in a previous pull request. The removal is applied consistently in two separate build stages within the Dockerfile, which seems correct. This likely resolves issues related to library conflicts or incorrect library resolution on systems where this compatibility layer is not needed. The change is straightforward and I don't see any issues with it.
Removed CUDA compatibility library loading commands from Dockerfile. Signed-off-by: Shang Wang <samshang.wang@mail.utoronto.ca>
ddb73ae to
3c1ae3d
Compare
|
Superseded with #33116. |
|
Superseded by #33992. |
|
Shouldn't this PR be closed then @wangshangsam ? |
|
Yes, it's redundant and has been implemented in #33992 with several improvements. |
Yep. Closing it now. |
Fixes #32373
Removed CUDA compatibility library loading commands from Dockerfile.
This PR fixes #32373 which is a bug introduced by #30784 .
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.