Skip to content

[Docker] Remove CUDA compatibility library loading; fixes #32373#32377

Closed
wangshangsam wants to merge 4 commits intovllm-project:mainfrom
CentML:wangshangsam/remove-ldconfig
Closed

[Docker] Remove CUDA compatibility library loading; fixes #32373#32377
wangshangsam wants to merge 4 commits intovllm-project:mainfrom
CentML:wangshangsam/remove-ldconfig

Conversation

@wangshangsam
Copy link
Copy Markdown
Collaborator

@wangshangsam wangshangsam commented Jan 15, 2026

Fixes #32373

Removed CUDA compatibility library loading commands from Dockerfile.

This PR fixes #32373 which is a bug introduced by #30784 .

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@wangshangsam wangshangsam changed the title Remove CUDA compatibility library loading [Docker] Remove CUDA compatibility library loading; fixes #32373 Jan 15, 2026
@wangshangsam wangshangsam self-assigned this Jan 15, 2026
@wangshangsam
Copy link
Copy Markdown
Collaborator Author

@huydhn there we go

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the CUDA compatibility library loading commands from the Dockerfile. The change is presented as a bug fix for an issue introduced in a previous pull request. The removal is applied consistently in two separate build stages within the Dockerfile, which seems correct. This likely resolves issues related to library conflicts or incorrect library resolution on systems where this compatibility layer is not needed. The change is straightforward and I don't see any issues with it.

Copy link
Copy Markdown
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for the fix!

Removed CUDA compatibility library loading commands from Dockerfile.

Signed-off-by: Shang Wang <samshang.wang@mail.utoronto.ca>
@wangshangsam wangshangsam force-pushed the wangshangsam/remove-ldconfig branch from ddb73ae to 3c1ae3d Compare January 16, 2026 03:37
@ehfd
Copy link
Copy Markdown
Contributor

ehfd commented Jan 29, 2026

Superseded with #33116.

@ehfd
Copy link
Copy Markdown
Contributor

ehfd commented Feb 26, 2026

Superseded by #33992.

@ivanbaldo
Copy link
Copy Markdown

Shouldn't this PR be closed then @wangshangsam ?

@ehfd
Copy link
Copy Markdown
Contributor

ehfd commented Feb 27, 2026

Yes, it's redundant and has been implemented in #33992 with several improvements.

@wangshangsam
Copy link
Copy Markdown
Collaborator Author

Shouldn't this PR be closed then @wangshangsam ?

Yep. Closing it now.

@github-project-automation github-project-automation bot moved this to Done in NVIDIA Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Fail to load vLLM on new NVIDIA driver

4 participants