Skip to content

fix: avoid crash on zero-arg tool calls in glm4 parser #32321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaunceyjiang merged 1 commit into from
Jan 15, 2026
+7 −1
Merged

fix: avoid crash on zero-arg tool calls in glm4 parser #32321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion vllm/tool_parsers/glm4_moe_tool_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,15 @@ def _deserialize(value: str) -> Any:
tool_calls = []
for match in matched_tool_calls:
tc_detail = self.func_detail_regex.search(match)
if not tc_detail:
logger.warning(
"Failed to parse tool call details from: %s",
match,
)
continue
tc_name = tc_detail.group(1)
tc_args = tc_detail.group(2)
pairs = self.func_arg_regex.findall(tc_args)
pairs = self.func_arg_regex.findall(tc_args) if tc_args else []
arg_dct = {}
for key, value in pairs:
arg_key = key.strip()
Expand Down