[Frontend] Standardize use of create_error_response#32319
Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom Jan 14, 2026
Merged
[Frontend] Standardize use of create_error_response#32319DarkLight1337 merged 2 commits intovllm-project:mainfrom
create_error_response#32319DarkLight1337 merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request effectively standardizes error handling by consistently using the create_error_response function and sanitizing error messages across numerous API endpoints. This is a significant improvement for code consistency and security. The centralization of exception handling for specific errors like OverflowError and NotImplementedError within create_error_response is a clean and robust approach. The changes in this PR are correct and well-executed. To fully complete this standardization effort, you might consider updating a few more locations in a follow-up, such as create_transcriptions, create_translations, and create_messages in vllm/entrypoints/openai/api_server.py, and detokenize in vllm/entrypoints/serve/tokenize/api_router.py, which still use the older error handling pattern. Overall, this is a valuable refactoring.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
5 tasks
sammysun0711
pushed a commit
to sammysun0711/vllm
that referenced
this pull request
Jan 16, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added a commit
that referenced
this pull request
Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
greg1232
pushed a commit
to supermassive-intelligence/vllm-fork
that referenced
this pull request
Jan 27, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
danichan-mkm
pushed a commit
to danichan-mkm/vllm
that referenced
this pull request
Feb 11, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Open
2 tasks
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dtrifiro
pushed a commit
to dtrifiro/vllm
that referenced
this pull request
Mar 9, 2026
…2319) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dtrifiro
added a commit
to dtrifiro/vllm
that referenced
this pull request
Mar 9, 2026
Fix: GHSA-4r2x-xpjr-7cvv - [Frontend] Improve error message (vllm-project#31987) - [Frontend] Standardize use of `create_error_response` (vllm-project#32319) - [Misc] Bump opencv-python dependecy version to 4.13 (vllm-project#32668) https://issues.redhat.com/browse/INFERENG-4411
Shafi-Hussain
pushed a commit
to odh-on-pz/vllm-cpu
that referenced
this pull request
Mar 17, 2026
Fix: GHSA-4r2x-xpjr-7cvv - [Frontend] Improve error message (vllm-project/vllm#31987) - [Frontend] Standardize use of `create_error_response` (vllm-project/vllm#32319) - [Misc] Bump opencv-python dependecy version to 4.13 (vllm-project/vllm#32668) https://issues.redhat.com/browse/INFERENG-4411 https://issues.redhat.com/browse/RHOAIENG-48365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #31987, ensure that the error message is sanitized properly.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.