Skip to content

[Build] Bump python openai version#32316

Merged
DarkLight1337 merged 9 commits intovllm-project:mainfrom
chaunceyjiang:bump_openai_version
Mar 18, 2026
Merged

[Build] Bump python openai version#32316
DarkLight1337 merged 9 commits intovllm-project:mainfrom
chaunceyjiang:bump_openai_version

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented Jan 14, 2026 •
edited by github-actions bot
Loading

Purpose

Upgrade OpenAI to version 2.0.0.

After v1.109, the next release is v2.x. This is just a minor version upgrade.

Test Plan

Test Result

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the openai package from version 1.x to 2.0.0. The code changes correctly handle a known API modification by removing a backward compatibility block. However, the PR description incorrectly classifies this as a minor version upgrade, when it is in fact a major one. This raises concerns about whether the full extent of potential breaking changes has been evaluated. I've added a comment to highlight the importance of thorough testing for this major dependency upgrade to prevent any potential regressions.

@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 28, 2026
@mergify
Copy link
Copy Markdown

mergify bot commented Feb 4, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

russellb
russellb approved these changes Feb 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mergify
Copy link
Copy Markdown

mergify bot commented Feb 13, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @chaunceyjiang.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Feb 13, 2026
@russellb
Copy link
Copy Markdown
Member

russellb commented Mar 13, 2026

The conflict with this PR is from #36471, which set an upper bound on the openai dependency. I think this change still makes sense to increase the lower bound.

@russellb russellb requested a review from DarkLight1337 as a code owner March 13, 2026 16:31
@mergify mergify bot removed the needs-rebase label Mar 13, 2026
@chaunceyjiang chaunceyjiang force-pushed the bump_openai_version branch 2 times, most recently from 4f3acf8 to 977db25 Compare March 17, 2026 03:33
@chaunceyjiang
Copy link
Copy Markdown
Collaborator Author

chaunceyjiang commented Mar 17, 2026

CI error ,see #37258

@chaunceyjiang chaunceyjiang changed the title [Build] Bump python openai version [WIP][Build] Bump python openai version Mar 17, 2026
@chaunceyjiang chaunceyjiang changed the title [WIP][Build] Bump python openai version [Build] Bump python openai version Mar 17, 2026
@chaunceyjiang
[Build] Bump python openai version
581fa0a 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
2334901 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
b487f13 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
8784085 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
752cac4 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
0e25460 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
8b7f419 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
cfa1630 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
[Build] Bump python openai version
60efeca 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang
Copy link
Copy Markdown
Collaborator Author

chaunceyjiang commented Mar 18, 2026

@DarkLight1337 PTAL.

@DarkLight1337 DarkLight1337 merged commit b322b19 into vllm-project:main Mar 18, 2026
132 checks passed
@chaunceyjiang chaunceyjiang deleted the bump_openai_version branch March 18, 2026 10:28
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
@chaunceyjiang @wendyliu235
[Build] Bump python openai version (vllm-project#32316)
aecf53e 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
fxdawnn pushed a commit to fxdawnn/vllm that referenced this pull request Mar 19, 2026
@chaunceyjiang @fxdawnn
[Build] Bump python openai version (vllm-project#32316)
a4dca78 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
SouthWest7 pushed a commit to SouthWest7/vllm that referenced this pull request Mar 27, 2026
@chaunceyjiang
[Build] Bump python openai version (vllm-project#32316)
10b2c62 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
khairulkabir1661 pushed a commit to khairulkabir1661/vllm that referenced this pull request Mar 27, 2026
@chaunceyjiang @khairulkabir1661
[Build] Bump python openai version (vllm-project#32316)
0194fc9 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Monishver11 pushed a commit to Monishver11/vllm that referenced this pull request Mar 27, 2026
@chaunceyjiang @Monishver11
[Build] Bump python openai version (vllm-project#32316)
2527688 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Monishver Chandrasekaran <monishverchandrasekaran@gmail.com>
JiantaoXu pushed a commit to JiantaoXu/vllm that referenced this pull request Mar 28, 2026
@chaunceyjiang @JiantaoXu
[Build] Bump python openai version (vllm-project#32316)
4b348d4 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Mar 30, 2026
@chaunceyjiang @vrdn-23
[Build] Bump python openai version (vllm-project#32316)
45b25e0 
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@russellb russellb russellb approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@aarnphm aarnphm Awaiting requested review from aarnphm aarnphm is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@NickLucche NickLucche Awaiting requested review from NickLucche NickLucche is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/build frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chaunceyjiang @russellb @DarkLight1337