Skip to content

[Bugfix] Refactor to support DP parallel in R3#32306

Merged
youkaichao merged 1 commit intovllm-project:mainfrom
xhx1022:r3_dp
Jan 16, 2026
Merged

[Bugfix] Refactor to support DP parallel in R3#32306
youkaichao merged 1 commit intovllm-project:mainfrom
xhx1022:r3_dp

Conversation

@xhx1022
Copy link
Copy Markdown
Contributor

@xhx1022 xhx1022 commented Jan 14, 2026

Fix a bug introduced during the DP parallel for R3(#28284).

@github-actions
Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify Bot added v1 bug Something isn't working labels Jan 14, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses a bug in data parallelism for routed experts. The changes correctly introduce rank-specific shared memory resources, preventing race conditions between data-parallel ranks. The logic for handling sharded data within the capture method is sound and properly slices tensors based on the data-parallel rank. Additionally, the refactoring to use the more general VllmConfig is a good improvement for code clarity and maintainability. Overall, the changes are correct and well-implemented.

@youkaichao youkaichao enabled auto-merge (squash) January 15, 2026 07:17
@github-actions github-actions Bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 15, 2026
@xhx1022
Copy link
Copy Markdown
Contributor Author

xhx1022 commented Jan 15, 2026

@Mergifyio rebase

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jan 15, 2026

rebase

✅ Branch has been successfully rebased

auto-merge was automatically disabled January 15, 2026 11:51

Head branch was pushed to by a user without write access

Signed-off-by: xhx1022 <1737006628@qq.com>
@xhx1022
Copy link
Copy Markdown
Contributor Author

xhx1022 commented Jan 16, 2026

@youkaichao

@youkaichao youkaichao merged commit 03da3b5 into vllm-project:main Jan 16, 2026
55 checks passed
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: xhx1022 <1737006628@qq.com>
Co-authored-by: arlenxu <arlenxu@tencent.com>
@xhx1022 xhx1022 deleted the r3_dp branch January 18, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants