Skip to content

Upgrade transformers-4.57.5#32287

Merged
DarkLight1337 merged 6 commits intovllm-project:mainfrom
huydhn:update-transformers-4.57.5
Jan 22, 2026
Merged

Upgrade transformers-4.57.5#32287
DarkLight1337 merged 6 commits intovllm-project:mainfrom
huydhn:update-transformers-4.57.5

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Jan 13, 2026

Purpose

https://pypi.org/project/transformers/4.57.5 is out today. Although there is already a PR to upgrade this to 5x #30566, I'm looking to get to 4.57.5 earlier to address this CI issue huggingface/transformers#42886

Test Plan

CI run

cc @hmellor

Signed-off-by: Huy Do <huydhn@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the transformers library to version 4.57.5 to address a CI issue. The changes are limited to updating the version in the requirements files (requirements/nightly_torch_test.txt, requirements/test.in, and requirements/test.txt). The modifications are straightforward and appear correct. This is a patch version bump, which should resolve the bug without introducing breaking changes. The changes look good.

@DarkLight1337 DarkLight1337 added the ready-run-all-tests Trigger CI with all tests for wide-ranging PRs label Jan 14, 2026
@huydhn
Copy link
Contributor Author

huydhn commented Jan 14, 2026

Lots of failures on PR, I need to check if they are existing issues or if they are coming out of this change

Signed-off-by: Huy Do <huydhn@gmail.com>
@mergify
Copy link

mergify bot commented Jan 19, 2026

Hi @huydhn, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

@huydhn huydhn force-pushed the update-transformers-4.57.5 branch from 2bb56c7 to 4c9b2be Compare January 19, 2026 21:42
@mergify
Copy link

mergify bot commented Jan 19, 2026

Hi @huydhn, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

@huydhn huydhn force-pushed the update-transformers-4.57.5 branch from 4c9b2be to c27f81a Compare January 19, 2026 21:48
@mergify
Copy link

mergify bot commented Jan 19, 2026

Hi @huydhn, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn force-pushed the update-transformers-4.57.5 branch from c27f81a to 784dafc Compare January 19, 2026 22:03
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn
Copy link
Contributor Author

huydhn commented Jan 20, 2026

@hmellor There is one legit failure left https://buildkite.com/vllm/ci/builds/47656#019bd8da-d61a-4f05-bcbd-8e0099a8590e/L2003, probably the same issue as the one reported in huggingface/transformers#43295. Do you have any suggestions on how to address it?

@DarkLight1337
Copy link
Member

You can skip the test according to transformers version until the HF Hub repo is updated to fix the issue

Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested a review from noooop as a code owner January 21, 2026 22:16
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Jan 21, 2026
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 22, 2026 04:20
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 22, 2026
@DarkLight1337 DarkLight1337 merged commit f5fdec8 into vllm-project:main Jan 22, 2026
147 of 148 checks passed
monajafi-amd pushed a commit to monajafi-amd/vllm that referenced this pull request Jan 23, 2026
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: mohammad najafi <mohammad.najafi@amd.com>
cwazai pushed a commit to cwazai/vllm that referenced this pull request Jan 25, 2026
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: 陈建华 <1647430658@qq.com>
lapy pushed a commit to lapy/vllm that referenced this pull request Jan 27, 2026
Signed-off-by: Huy Do <huydhn@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Huy Do <huydhn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed ready-run-all-tests Trigger CI with all tests for wide-ranging PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants