Upgrade transformers-4.57.5#32287
Conversation
Signed-off-by: Huy Do <huydhn@gmail.com>
There was a problem hiding this comment.
Code Review
This pull request upgrades the transformers library to version 4.57.5 to address a CI issue. The changes are limited to updating the version in the requirements files (requirements/nightly_torch_test.txt, requirements/test.in, and requirements/test.txt). The modifications are straightforward and appear correct. This is a patch version bump, which should resolve the bug without introducing breaking changes. The changes look good.
|
Lots of failures on PR, I need to check if they are existing issues or if they are coming out of this change |
Signed-off-by: Huy Do <huydhn@gmail.com>
|
Hi @huydhn, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
2bb56c7 to
4c9b2be
Compare
|
Hi @huydhn, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
4c9b2be to
c27f81a
Compare
|
Hi @huydhn, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Huy Do <huydhn@gmail.com>
c27f81a to
784dafc
Compare
|
@hmellor There is one legit failure left https://buildkite.com/vllm/ci/builds/47656#019bd8da-d61a-4f05-bcbd-8e0099a8590e/L2003, probably the same issue as the one reported in huggingface/transformers#43295. Do you have any suggestions on how to address it? |
|
You can skip the test according to transformers version until the HF Hub repo is updated to fix the issue |
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com> Signed-off-by: mohammad najafi <mohammad.najafi@amd.com>
Signed-off-by: Huy Do <huydhn@gmail.com> Signed-off-by: 陈建华 <1647430658@qq.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
Purpose
https://pypi.org/project/transformers/4.57.5 is out today. Although there is already a PR to upgrade this to 5x #30566, I'm looking to get to
4.57.5earlier to address this CI issue huggingface/transformers#42886Test Plan
CI run
cc @hmellor