Skip to content

[Refactor] [6/N] to simplify the vLLM openai chat_completion serving architecture#32240

Merged
chaunceyjiang merged 12 commits intovllm-project:mainfrom
chaunceyjiang:vllm_open_refactor
Jan 13, 2026
Merged

[Refactor] [6/N] to simplify the vLLM openai chat_completion serving architecture#32240
chaunceyjiang merged 12 commits intovllm-project:mainfrom
chaunceyjiang:vllm_open_refactor

Conversation

@chaunceyjiang
Copy link
Copy Markdown
Collaborator

@chaunceyjiang chaunceyjiang commented Jan 13, 2026

Purpose

refactors the OpenAI chat_completion_serving architecture,

split vllm/entrypoints/openai/protocol.py
TODO
[ ] completion_serving
[ ] responses_serving
[ ] transcription_serving
[ ] tests re-org
[ ] compatibility with the previous import of vllm/entrypoints/openai/protocol.py

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@mergify mergify bot added deepseek Related to DeepSeek models frontend llama Related to Llama models qwen Related to Qwen models gpt-oss Related to GPT-OSS models labels Jan 13, 2026
@chaunceyjiang chaunceyjiang changed the title [Refactor] [6/N] to simplify the vLLM openai serving architecture [Refactor] [6/N] to simplify the vLLM openai chat_completion serving architecture Jan 13, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the OpenAI serving architecture by restructuring files and updating import paths. The changes are mostly mechanical, but I found a couple of critical issues in the newly added vllm/entrypoints/openai/chat_completion/protocol.py file: a syntax error in an import statement and a missing import for FunctionDefinition. These issues will prevent the code from running and need to be addressed.

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label Jan 13, 2026
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 13, 2026
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as tests pass

@github-project-automation github-project-automation bot moved this from To Triage to Ready in gpt-oss Issues & Enhancements Jan 13, 2026
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang enabled auto-merge (squash) January 13, 2026 11:14
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
@chaunceyjiang chaunceyjiang enabled auto-merge (squash) January 13, 2026 11:18
@chaunceyjiang chaunceyjiang merged commit fefce49 into vllm-project:main Jan 13, 2026
50 checks passed
@chaunceyjiang chaunceyjiang deleted the vllm_open_refactor branch January 13, 2026 13:06
sammysun0711 pushed a commit to sammysun0711/vllm that referenced this pull request Jan 16, 2026
…architecture (vllm-project#32240)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
…architecture (vllm-project#32240)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…architecture (vllm-project#32240)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
…architecture (vllm-project#32240)

Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deepseek Related to DeepSeek models frontend gpt-oss Related to GPT-OSS models llama Related to Llama models multi-modality Related to multi-modality (#4194) qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed tool-calling v1

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants