[Frontend]: minimax_m2 supports structural_tag#32232
[Frontend]: minimax_m2 supports structural_tag#32232chaunceyjiang wants to merge 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
|
Documentation preview: https://vllm--32232.org.readthedocs.build/en/32232/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for structural_tag in the minimax_m2 tool parser. This is a nice enhancement, enabling more robust tool calling for MiniMax M2 models by leveraging structured outputs. The changes involve implementing the prepare_structured_tags method to dynamically construct the necessary schema and updating an example file for testing.
My review has identified several instances of leftover debug print statements across different files. These should be removed to maintain clean logs. More critically, I've found an issue in vllm/tool_parsers/minimax_m2_tool_parser.py where the extract_tool_calls method for non-streaming responses has been effectively disabled, which could break existing functionality. Please address these points.
| return ExtractedToolCallInformation( | ||
| tools_called=False, tool_calls=[], content=model_output | ||
| ) |
There was a problem hiding this comment.
This early return effectively disables the entire extract_tool_calls method, causing non-streaming tool call extraction to fail. The method will always return an empty list of tool calls, regardless of the model output. This appears to be a critical issue that breaks existing functionality.
| print("Structured outputs params:") | ||
| print(self.structured_outputs) |
There was a problem hiding this comment.
These appear to be debug print statements. They should be removed before merging to avoid polluting production logs.
| request.response_format = StructuralTagResponseFormat( | ||
| type="structural_tag", format=structured_tags["format"] | ||
| ) | ||
| print(structured_tags) |
There was a problem hiding this comment.
This print statement seems to be for debugging purposes. Please remove it before merging to keep the logs clean.
| print("1*1" * 20) | ||
| print(s_tag) |
There was a problem hiding this comment.
These print statements appear to be for debugging. Please remove them to avoid unnecessary output in the logs.
| print("*" * 20) | ||
| print(s_tag) |
There was a problem hiding this comment.
These print statements look like they were added for debugging. They should be removed before this pull request is merged.
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
| # "type": "const_string", | ||
| # "value": "...", | ||
| # }, # debug | ||
| "content": {"type": "any_text"}, |
There was a problem hiding this comment.
|
This pull request has merge conflicts that must be resolved before it can be |
Mark PR vllm-project#33303 as applied. Add additional MiniMax-specific PRs: - vllm-project#34863: compressed-tensors FP8 scale propagation - vllm-project#32232: structural_tag support - vllm-project#35358: reasoning-end detection fix
Mark PR vllm-project#33303 as applied. Add additional MiniMax-specific PRs: - vllm-project#34863: compressed-tensors FP8 scale propagation - vllm-project#32232: structural_tag support - vllm-project#35358: reasoning-end detection fix
1 participant
Purpose
follow up #32142
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.