[BugFix] fix FusedMoE.make_expert_params_mapping in EXAONE-MoE#32196
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Jan 12, 2026
Merged
[BugFix] fix FusedMoE.make_expert_params_mapping in EXAONE-MoE#32196vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: lkm2835 <lkm2835@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in ExaoneMoeModel.get_expert_mapping by passing self as the model argument to the FusedMoE.make_expert_params_mapping class method. The original implementation was missing this required argument, which would result in a TypeError at runtime. The change is accurate and resolves the issue.
Contributor
Author
|
@DarkLight1337, could you help review this PR? |
DarkLight1337
approved these changes
Jan 12, 2026
TomerBN-Nvidia
pushed a commit
to TomerBN-Nvidia/vllm
that referenced
this pull request
Jan 13, 2026
…project#32196) Signed-off-by: lkm2835 <lkm2835@gmail.com> Signed-off-by: Tomer Natan <tbarnatan@computelab-frontend-8.nvidia.com>
sammysun0711
pushed a commit
to sammysun0711/vllm
that referenced
this pull request
Jan 16, 2026
…project#32196) Signed-off-by: lkm2835 <lkm2835@gmail.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…project#32196) Signed-off-by: lkm2835 <lkm2835@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…project#32196) Signed-off-by: lkm2835 <lkm2835@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…project#32196) Signed-off-by: lkm2835 <lkm2835@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Added the missing changes.
Related to #31104.
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.Note
Fixes expert parameter mapping for EXAONE-MoE.
get_expert_mappingto passselfintoFusedMoE.make_expert_params_mapping, ensuring correct mapping/loading of expert weights (including redundant experts).Written by Cursor Bugbot for commit 370629e. This will update automatically on new commits. Configure here.