Skip to content

[Misc] Delay deprecation of CommonAttentionMetadata properties#32074

Merged
vllm-bot merged 1 commit intovllm-project:mainfrom
neuralmagic:lwlkinson/delay-deprecation
Jan 10, 2026
Merged

[Misc] Delay deprecation of CommonAttentionMetadata properties#32074
vllm-bot merged 1 commit intovllm-project:mainfrom
neuralmagic:lwlkinson/delay-deprecation

Conversation

@LucasWilkinson
Copy link
Copy Markdown
Collaborator

@LucasWilkinson LucasWilkinson commented Jan 10, 2026

Tracking progress here: #32072

Unfortunately the last 2 PR

Are a bit trickier and do not appear to be on track to v0.14; delay just in case


Note

Delays removal timeline for deprecated CPU-based fields and accessors in attention metadata.

  • Update deprecation notes/comments in CommonAttentionMetadata so seq_lens_cpu and num_computed_tokens_cpu (and related fields) are marked for removal in v0.15.0 instead of v0.14.0

Written by Cursor Bugbot for commit 705bc8f. This will update automatically on new commits. Configure here.

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@LucasWilkinson LucasWilkinson added this to the v0.14.0 milestone Jan 10, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the deprecation version for several properties in CommonAttentionMetadata from v0.14.0 to v0.15.0. The changes are limited to comments and docstrings and are consistent with the goal of delaying the deprecation. The modifications are correct and I have no further feedback.

@mergify mergify bot added the v1 label Jan 10, 2026
@vllm-bot vllm-bot merged commit da6709c into vllm-project:main Jan 10, 2026
11 of 12 checks passed
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…project#32074)

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants