[Fix] Avoid pickling entire LLMEngine for Ray workers#3207
Merged
Yard1 merged 4 commits intovllm-project:mainfrom Mar 6, 2024
Merged
[Fix] Avoid pickling entire LLMEngine for Ray workers#3207Yard1 merged 4 commits intovllm-project:mainfrom
Yard1 merged 4 commits intovllm-project:mainfrom
Conversation
Yard1
approved these changes
Mar 5, 2024
Collaborator
Yard1
left a comment
Yard1
left a comment
There was a problem hiding this comment.
Looks good, can you add a short description?
Collaborator
|
You can implement the |
Member
Author
|
Good idea @simon-mo, now added. |
Yard1
reviewed
Mar 5, 2024
Yard1
reviewed
Mar 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
selfreferences have been inadvertently introduced into the closure used to initialize the Ray workers, which is causing the wholeLLMEngineobject to be pickled with it.This fixes it to reference the
lora_configandkv_cache_dtypedirectly.