Skip to content

[MLA] Support DCP + FP8#32014

Draft
LucasWilkinson wants to merge 1 commit intovllm-project:mainfrom
neuralmagic:lwilkinson/fp8-dcp
Draft

[MLA] Support DCP + FP8#32014
LucasWilkinson wants to merge 1 commit intovllm-project:mainfrom
neuralmagic:lwilkinson/fp8-dcp

Conversation

@LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Jan 9, 2026

FIX #32010

Signed-off-by: Lucas Wilkinson lwilkins@redhat.com

Signed-off-by: Lucas Wilkinson <lwilkins@redhat.com>
@mergify mergify bot added the v1 label Jan 9, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Decode Context Parallelism (DCP) with FP8 KV cache in Multi-head Latent Attention (MLA). The changes involve removing assertions that previously blocked this combination, replacing a specialized cache gathering operation with a more general one that handles dequantization, and updating the decode path to correctly process FP8 tensors with DCP. The changes appear correct and consistent with the goal of enabling this feature. I have not found any high or critical severity issues in this pull request.

@mergify
Copy link

mergify bot commented Jan 13, 2026

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Jan 13, 2026
@grimulkan
Copy link
Contributor

@LucasWilkinson Are you still working on this? Otherwise I can do a separate compatibility PR where DCP works as it currently does (in bf16) and then quantizes to fp8 if that's what is needed. It unlocks usage of fp8 KV Cache with DCP, leaving the optimization of DCP comms for later. That's the idea in principle at least, haven't fully tested it out.

Any preferences?

This would synergize with #34597 on expanding Triton MLA to fp8 KV.

@grimulkan
Copy link
Contributor

I added a new rebased PR that supports this feature + tests: #34795
I am happy to close it or merge with this one if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Support DCP with FP8 KV Cache

2 participants