Skip to content

[Bugfix] Fix Fp8 Triton for non-gated MoE (Nemotron) #31983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danisereb wants to merge 2 commits into from
Closed

[Bugfix] Fix Fp8 Triton for non-gated MoE (Nemotron) #31983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e51a9d
Fix ModelOptFp8MoEMethod for non-gated MoE
danisereb Jan 8, 2026
7d08280
Add Nemotron Nano V3 BF16 to moe-refactor evals
danisereb Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/evals/gsm8k/configs/moe-refactor/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16-triton.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
model_name: "nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16"
Copy link
Copy Markdown
Member

@mgoin mgoin Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a BF16 model, not FP8?

Copy link
Copy Markdown
Contributor Author

@danisereb danisereb Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was discussed in slack channel with us.
This PR can be closed.

accuracy_threshold: 0.85
num_questions: 1319
num_fewshot: 10
server_args: "--enforce-eager --max-model-len 8192 --tensor-parallel-size 2"
1 change: 1 addition & 0 deletions tests/evals/gsm8k/configs/moe-refactor/config-b200.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ Qwen3-30B-A3B-NvFp4-ModelOpt-marlin.yaml
Qwen3-30B-A3B-NvFp4-ModelOpt-fi-trtllm.yaml
Qwen3-30B-A3B-NvFp4-ModelOpt-fi-cutlass.yaml
Qwen3-30B-A3B-NvFp4-ModelOpt-fi-cutlass-dp-ep.yaml
NVIDIA-Nemotron-3-Nano-30B-A3B-BF16-triton.yaml
1 change: 1 addition & 0 deletions vllm/model_executor/layers/quantization/modelopt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,6 +733,7 @@ def __init__(
block_quant=False,
tp_size=moe_config.moe_parallel_config.tp_size,
with_lora_support=self.moe.is_lora_enabled,
is_act_and_mul=self.moe.is_act_and_mul,
Copy link
Copy Markdown
Contributor Author

@danisereb danisereb Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was fixed in another PR:
#32257

)
self.kernel: mk.FusedMoEModularKernel | None = None

Expand Down