Skip to content

[Doc] Improve MM models LoRA notes#31979

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
jeejeelee:improve-lora-note
Jan 8, 2026
Merged

[Doc] Improve MM models LoRA notes#31979
DarkLight1337 merged 2 commits intovllm-project:mainfrom
jeejeelee:improve-lora-note

Conversation

@jeejeelee
Copy link
Copy Markdown
Collaborator

@jeejeelee jeejeelee commented Jan 8, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@mergify
Copy link
Copy Markdown

mergify bot commented Jan 8, 2026

Documentation preview: https://vllm--31979.org.readthedocs.build/en/31979/

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 8, 2026
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 8, 2026 16:24
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the documentation for multimodal (MM) models and their LoRA support. It updates the compatibility tables for several models, including DotsOCR, Grok2, IQuestCoderV1, IQuestLoopCoderV1, LFM2-VL, Pixtral, Qwen3-VL, and Qwen3-VL-Reranker, reflecting expanded LoRA and parallelism capabilities. Notably, the detailed Python code for merging LoRA weights in multimodal encoders has been removed, replaced by a more concise note indicating experimental direct support for LoRA in tower and connector modules. This suggests an enhancement in vLLM's native capabilities, simplifying the user experience. The addition of specific --hf_overrides instructions for Grok2 and Qwen3-VL-Reranker further aids users in configuring these models correctly. Overall, these changes enhance clarity and provide up-to-date information on multimodal model integration and LoRA usage within vLLM.

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 8, 2026
@DarkLight1337 DarkLight1337 merged commit 49568d5 into vllm-project:main Jan 8, 2026
9 of 10 checks passed
@jeejeelee jeejeelee deleted the improve-lora-note branch January 8, 2026 17:12
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants