[ROCm][AITER] fix wrong argument passed to AITER flash_attn_varlen_func#31880
Merged
tjtanaa merged 1 commit intovllm-project:mainfrom Jan 7, 2026
Merged
[ROCm][AITER] fix wrong argument passed to AITER flash_attn_varlen_func#31880tjtanaa merged 1 commit intovllm-project:mainfrom
flash_attn_varlen_func#31880tjtanaa merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects a critical bug in the AITER attention backends for ROCm. The argument return_softmax_lse was being incorrectly passed to flash_attn_varlen_func from the aiter package. This has been fixed by changing it to the correct argument name, return_lse. This change prevents a runtime TypeError and is essential for the correct functioning of the AITER backends. The fix is applied in both aiter_triton_mla.py and rocm_aiter_mla.py. The changes are correct and necessary.
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
…unc` (vllm-project#31880) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…unc` (vllm-project#31880) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…unc` (vllm-project#31880) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…unc` (vllm-project#31880) Signed-off-by: vllmellm <vllm.ellm@embeddedllm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This #31465 PR changed arguments name into wrong one that doesn't exist in
aiter package.This PR fixes the issue.
Test Plan
commands:
ROCM_AITER_MLA backend
export VLLM_USE_V1=1 export SAFETENSORS_FAST_GPU=1 export VLLM_ROCM_USE_AITER=1 export VLLM_ATTENTION_BACKEND=ROCM_AITER_MLA vllm serve deepseek-ai/DeepSeek-V3 \ --block-size 128 \ -tp 8 >ROCM_AITER_TRITON_MLA
export VLLM_USE_V1=1 export SAFETENSORS_FAST_GPU=1 export VLLM_ROCM_USE_AITER=1 export VLLM_ATTENTION_BACKEND=ROCM_AITER_TRITON_MLA vllm serve deepseek-ai/DeepSeek-V3 \ --block-size 128 \ -tp 8lm_eval --model local-completions \ --tasks gsm8k \ --model_args model=deepseek-ai/DeepSeek-V3,base_url=http://localhost:8000/v1/completions \ --trust_remote_code \ --num_fewshot 5 \ --limit 300 \ --batch_size 128Test Result
ROCM_AITER_MLA backend
ROCM_AITER_TRITON_MLA
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.