[NemotronH] Use ReplicatedLinear for fc1_latent_proj#31807
Merged
tlrmchlsmth merged 1 commit intovllm-project:mainfrom Jan 6, 2026
Merged
[NemotronH] Use ReplicatedLinear for fc1_latent_proj#31807tlrmchlsmth merged 1 commit intovllm-project:mainfrom
tlrmchlsmth merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: Roi Koren <roik@nvidia.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces ColumnParallelLinear with ReplicatedLinear for the fc1_latent_proj layer in the latent MoE implementation. As described, this is a sound performance optimization for a relatively small layer, trading a small increase in VRAM for a reduction in synchronization overhead. The code change is correct and well-contained. I approve this change.
tlrmchlsmth
reviewed
Jan 6, 2026
Member
tlrmchlsmth
left a comment
There was a problem hiding this comment.
Anything you can share on the performance difference? Mainly just curious
tlrmchlsmth
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Current implementation of latent MoE uses a ColumnParallelLinear for the
fc1_latent_projlayer. After profiling, the synchronization overhead is quite substantial, and given that the layer itself is relatively small, replicating it instead improves performance while not costing too much in terms of VRAM usage.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.