[Quantization][Refactor] Move CPU GPTQ kernel into MP linear#31801
Merged
robertgshaw2-redhat merged 4 commits intovllm-project:mainfrom Jan 6, 2026
Merged
[Quantization][Refactor] Move CPU GPTQ kernel into MP linear#31801robertgshaw2-redhat merged 4 commits intovllm-project:mainfrom
robertgshaw2-redhat merged 4 commits intovllm-project:mainfrom
Conversation
bigPYJ1151
requested review from
ProExpertProg,
WoosukKwon,
hmellor,
houseroad,
mgoin,
pavanimajety,
robertgshaw2-redhat,
tlrmchlsmth,
yewentao256 and
youkaichao
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the CPU GPTQ kernel by integrating it into the Mixed-Precision (MP) linear layer framework. This is a good architectural improvement, moving the logic into a new CPUWNA16LinearKernel and extending the gptq_marlin quantization to support CPU. While the overall direction is positive, I've identified a couple of critical issues in the implementation that need to be addressed to ensure correctness.
vllm/model_executor/layers/quantization/kernels/mixed_precision/cpu.py
Outdated
Show resolved
Hide resolved
…n/cpu.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Li, Jiang <bigpyj64@gmail.com> Signed-off-by: jiang1.li <jiang1.li@intel.com>
bigPYJ1151
force-pushed
the
reorg_wna16
branch
from
43c75fa to
05d7795
Compare
Collaborator
|
nice job |
Collaborator
|
LGTM |
robertgshaw2-redhat
approved these changes
Jan 6, 2026
robertgshaw2-redhat
added
the
ready
Signed-off-by: jiang1.li <jiang1.li@intel.com>
Comment on lines
+20
to
+22
| @classmethod | ||
| def get_min_capability(cls) -> int: | ||
| return -1 |
Collaborator
There was a problem hiding this comment.
We should change this to a is_supported idiom instead of min_capability, #31821.
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
…oject#31801) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Li, Jiang <bigpyj64@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…oject#31801) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Li, Jiang <bigpyj64@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…oject#31801) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Li, Jiang <bigpyj64@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…oject#31801) Signed-off-by: jiang1.li <jiang1.li@intel.com> Signed-off-by: Li, Jiang <bigpyj64@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
part of #31689
Test Plan
https://buildkite.com/vllm/fastcheck/builds/44891#019b92e9-b55f-4146-a633-3e486ac0da68
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.