Skip to content

[CI] Increase the MTEB_EMBED_TOL threshold to 5e-4.#31797

Merged
noooop merged 1 commit intovllm-project:mainfrom
noooop:update_MTEB_EMBED_TOL
Jan 6, 2026
Merged

[CI] Increase the MTEB_EMBED_TOL threshold to 5e-4.#31797
noooop merged 1 commit intovllm-project:mainfrom
noooop:update_MTEB_EMBED_TOL

Conversation

@noooop
Copy link
Copy Markdown
Collaborator

@noooop noooop commented Jan 6, 2026

Purpose

Increase the MTEB_EMBED_TOL threshold to 5e-4.

models/language/pooling_mteb_test/test_nemotron.py::test_embed_models_mteb[model_info0] in Language Models Test (MTEB) is a bit flaky lately.

https://buildkite.com/vllm/ci/builds/45475/steps/canvas?jid=019b8e61-5af4-47fe-b434-87827f0b7778
https://buildkite.com/vllm/ci/builds/45466/steps/canvas?jid=019b8d9c-2547-4e56-a104-6fa4e8077d85

There's a relatively high probability of encountering this.

Test Plan

models/language/pooling_mteb_test/

Test Result

pass


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop requested a review from DarkLight1337 January 6, 2026 09:12
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the tolerance for MTEB embedding tests from 1e-4 to 5e-4 to address test flakiness. Additionally, it removes explicit dtype="float32" configurations from several embedding model tests, allowing them to use the default auto dtype which typically resolves to a lower precision like float16. These changes are consistent, as using lower precision can lead to larger numerical differences, thus requiring a higher tolerance. The modifications seem reasonable for improving test stability and expanding test coverage to lower-precision data types. I have not found any issues with these changes.

@noooop noooop added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 6, 2026
@noooop noooop merged commit 43d384b into vllm-project:main Jan 6, 2026
22 of 23 checks passed
LucasWilkinson pushed a commit to neuralmagic/vllm that referenced this pull request Jan 6, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
@noooop noooop deleted the update_MTEB_EMBED_TOL branch January 19, 2026 03:13
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants