[CI] Increase the MTEB_EMBED_TOL threshold to 5e-4.#31797
Merged
noooop merged 1 commit intovllm-project:mainfrom Jan 6, 2026
Merged
[CI] Increase the MTEB_EMBED_TOL threshold to 5e-4.#31797noooop merged 1 commit intovllm-project:mainfrom
noooop merged 1 commit intovllm-project:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the tolerance for MTEB embedding tests from 1e-4 to 5e-4 to address test flakiness. Additionally, it removes explicit dtype="float32" configurations from several embedding model tests, allowing them to use the default auto dtype which typically resolves to a lower precision like float16. These changes are consistent, as using lower precision can lead to larger numerical differences, thus requiring a higher tolerance. The modifications seem reasonable for improving test stability and expanding test coverage to lower-precision data types. I have not found any issues with these changes.
DarkLight1337
approved these changes
Jan 6, 2026
LucasWilkinson
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jan 6, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: wang.yuqi <yuqi.wang@daocloud.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Increase the MTEB_EMBED_TOL threshold to 5e-4.
models/language/pooling_mteb_test/test_nemotron.py::test_embed_models_mteb[model_info0] in Language Models Test (MTEB) is a bit flaky lately.
https://buildkite.com/vllm/ci/builds/45475/steps/canvas?jid=019b8e61-5af4-47fe-b434-87827f0b7778
https://buildkite.com/vllm/ci/builds/45466/steps/canvas?jid=019b8d9c-2547-4e56-a104-6fa4e8077d85
There's a relatively high probability of encountering this.
Test Plan
models/language/pooling_mteb_test/
Test Result
pass
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.