Skip to content

[ci] fix timm import error #31795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andyxning wants to merge 1 commit into from
+2 −0
Closed

[ci] fix timm import error #31795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/test-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -841,6 +841,7 @@ steps:
no_gpu: true
commands:
- "pip install git+https://github.com/TIGER-AI-Lab/Mantis.git || echo 'Mantis installation skipped (decord not available on CPU-only environment)'"
- pip install timm==1.0.22
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While pinning timm==1.0.22 correctly fixes the import error, installing it directly in the CI script is not ideal for long-term maintainability, especially since this change is duplicated in another file (.buildkite/test_areas/models_multimodal.yaml).

A better approach would be to manage this dependency in a centralized requirements file. Please consider updating requirements/test.in to specify timm==1.0.22, and then regenerate requirements/test.txt. This will ensure consistency and make future dependency management easier.

- pytest -v -s models/multimodal/processing --ignore models/multimodal/processing/test_tensor_schema.py

- label: Multi-Modal Processor Test
Expand Down
1 change: 1 addition & 0 deletions .buildkite/test_areas/models_multimodal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ steps:
no_gpu: true
commands:
- pip install git+https://github.com/TIGER-AI-Lab/Mantis.git
- pip install timm==1.0.22
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

As mentioned in the comment for .buildkite/test-pipeline.yaml, hardcoding the timm version here creates duplication and a maintenance burden. It would be best to consolidate this dependency pin into the requirements/test.in file and regenerate the corresponding requirements.txt.

- pytest -v -s models/multimodal/processing --ignore models/multimodal/processing/test_tensor_schema.py

- label: Multi-Modal Processor # 44min
Expand Down
Loading