[Bugfix]: avoid overriding audio/text kwargs (Qwen3-Omni)#31790
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Jan 6, 2026
Merged
[Bugfix]: avoid overriding audio/text kwargs (Qwen3-Omni)#31790DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337 merged 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an issue where user-provided audio_kwargs and text_kwargs were being overwritten in the Qwen3OmniMoeThinker multimodal processor. The change ensures that existing dictionary contents are preserved by safely updating the truncation setting instead of reassigning the dictionaries. This is a good fix that improves the robustness of multimodal argument handling for older versions of the transformers library. The implementation is clean and correct.
Jzz1943
force-pushed
the
qwen3-kwargs-fix
branch
from
1bdd000 to
0ede05a
Compare
Jzz1943
changed the title
DarkLight1337
approved these changes
Jan 6, 2026
Jzz1943
changed the title
Member
|
Thanks! |
Jzz1943
changed the title
github-actions
bot
added
the
ready
Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com>
auto-merge was automatically disabled
January 6, 2026 11:09
Head branch was pushed to by a user without write access
Jzz1943
force-pushed
the
qwen3-kwargs-fix
branch
from
0ede05a to
dec241b
Compare
Anexdeus
pushed a commit
to Anexdeus/vllm
that referenced
this pull request
Jan 6, 2026
…ct#31790) Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com> Signed-off-by: Anexdeus <5142168@mail.ru>
LucasWilkinson
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Jan 6, 2026
…ct#31790) Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com>
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
…ct#31790) Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
…ct#31790) Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…ct#31790) Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…ct#31790) Signed-off-by: Zhongze Jiang <jiangzhongze.jzz@ant-intl.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in Qwen3OmniMoeThinker where
audio_kwargs/text_kwargscould be overridden when restructuring kwargs forTransformers < 4.58.0.We now preserve existing nested kwargs and only set truncation as a default, allowing
audio_kwargs/text_kwargsto take precedence when provided by user.