[Frontend] Support GLM-4.5 / GLM-4.7 with enable_thinking: false

[chaunceyjiang]

Purpose

[Frontend] Support GLM-4.5 / GLM-4.7 with enable_thinking: false

FIX #31319
FIX #31449 (comment)

Test Plan

Test Result

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[gemini-code-assist]

Code Review

This pull request aims to add support for GLM-4.5/GLM-4.7 models, particularly handling the enable_thinking: false parameter. The changes involve updating reasoning parsers.

My review found a critical logic issue in holo2_reasoning_parser.py where the or operator is used incorrectly, preventing the enable_thinking: false flag from disabling the thinking feature as intended. I've suggested using and instead. Additionally, I've pointed out an outdated docstring in glm4_moe_reasoning_parser.py that needs to be updated to reflect the new class inheritance.

[chaunceyjiang]

/cc @hhd52859 @zhangsongqing @athenacykes Could you help test this?

[hhd52859]

/cc @hhd52859 @zhangsongqing @athenacykes Could you help test this?

LGTM, thanks!

[chaunceyjiang]

/cc @zRzRzRzRzRzRzR PTAL

[JaredforReal]

@chaunceyjiang not working well, extra_body ignored

[JaredforReal]

@chaunceyjiang try working on protocol.py, appreciate that

[cjackal]

So in effect glm45 reasoning parser is --reasoning-parser deepseek_v3 --default-chat-template-kwargs {"enable_thinking":true}. After #31581 reasoning parsets handle default chat template kwargs well, FYI.

[chaunceyjiang]

So in effect glm45 reasoning parser is --reasoning-parser deepseek_v3 --default-chat-template-kwargs {"enable_thinking":true}. After #31581 reasoning parsets handle default chat template kwargs well, FYI.

@cjackal Yes. This is more of a workaround. The root cause is still an incorrect implementation of the GLM45 reasoning parser.

[chaunceyjiang]

@chaunceyjiang not working well, extra_body ignored

@JaredforReal, could you share your client code? I think the issue is with the client-side code.

[JaredforReal]

@chaunceyjiang Thanks！

[chaunceyjiang]

cc @DarkLight1337 PTAL

[mballesterosc]

In streaming mode, when {"chat_template_kwargs":{"enable_thinking": False}} is set, output is encapsuled in <think></think> tags, it is intended?

Thanks

[RocketRider]

In streaming mode, when {"chat_template_kwargs":{"enable_thinking": False}} is set, output is encapsuled in <think></think> tags, it is intended?

Thanks

Did you test it with the latest nightly?
For me it is fixed with the latest version.

[mballesterosc]

In streaming mode, when {"chat_template_kwargs":{"enable_thinking": False}} is set, output is encapsuled in <think></think> tags, it is intended?
Thanks

Did you test it with the latest nightly? For me it is fixed with the latest version.

I'm sorry, I tried with the nightly build from the day the pull request was closed, and it's OK now. Thank you.