Skip to content

[Chore] Remove more V0 dead code from sequence.py#31783

Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337:rm-v0-code
Jan 6, 2026
Merged

[Chore] Remove more V0 dead code from sequence.py#31783
DarkLight1337 merged 1 commit intovllm-project:mainfrom
DarkLight1337:rm-v0-code

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Jan 6, 2026

Purpose

This code isn't used anymore so we can easily remove them.

We can move IntermediateTensors to a more suitable location in another PR.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on removing dead code, specifically the RequestMetrics dataclass and the constants VLLM_TOKEN_ID_ARRAY_TYPE and VLLM_INVALID_TOKEN_ID from vllm/sequence.py. Correspondingly, the usage of RequestMetrics has been removed from vllm/outputs.py. My review confirms that this code is indeed unused across the provided files. The changes are correct and contribute to better code maintainability by reducing clutter. The pull request is well-scoped and looks good to merge.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 6, 2026 07:08
@DarkLight1337 DarkLight1337 merged commit 97ca4c3 into vllm-project:main Jan 6, 2026
48 checks passed
@DarkLight1337 DarkLight1337 deleted the rm-v0-code branch January 6, 2026 10:25
LucasWilkinson pushed a commit to neuralmagic/vllm that referenced this pull request Jan 6, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants