[Misc] Use deprecated for seed_everything#31780
[Misc] Use deprecated for seed_everything#31780DarkLight1337 merged 2 commits intovllm-project:mainfrom
deprecated for seed_everything#31780Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Code Review
This pull request correctly updates the deprecation mechanism for seed_everything to use the @deprecated decorator, aligning with the project's policy. However, by removing the explicit logging call, the deprecation warning may become invisible to users due to Python's default warning handling. I've recommended re-introducing a log message to ensure users are properly notified of the change, which seems to be in the spirit of the deprecation policy that mentions both log output and the decorator.
|
Thanks, it's better. And the doc should be update https://github.com/vllm-project/vllm/blob/main/docs/design/plugin_system.md#deprecation-announcement |
|
Updated. Also updated benchmarks that use the deprecated method. |
|
Documentation preview: https://vllm--31780.org.readthedocs.build/en/31780/ |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Purpose
Use
deprecateddecorator to emit a warning message. Also changed the removal date to v0.15 as we are close to v0.14 already.I also found various benchmarks that use the deprecated method, so I've updated them accordingly.
cc @wangxiyuan
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.