Skip to content

[Misc] Use deprecated for seed_everything#31780

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337:deprecate-seed-anything
Jan 6, 2026
Merged

[Misc] Use deprecated for seed_everything#31780
DarkLight1337 merged 2 commits intovllm-project:mainfrom
DarkLight1337:deprecate-seed-anything

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Jan 6, 2026

Purpose

Use deprecated decorator to emit a warning message. Also changed the removal date to v0.15 as we are close to v0.14 already.

I also found various benchmarks that use the deprecated method, so I've updated them accordingly.

cc @wangxiyuan

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 6, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the deprecation mechanism for seed_everything to use the @deprecated decorator, aligning with the project's policy. However, by removing the explicit logging call, the deprecation warning may become invisible to users due to Python's default warning handling. I've recommended re-introducing a log message to ensure users are properly notified of the change, which seems to be in the spirit of the deprecation policy that mentions both log output and the decorator.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 6, 2026 07:08
@wangxiyuan
Copy link
Copy Markdown
Contributor

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337
Copy link
Copy Markdown
Member Author

Updated. Also updated benchmarks that use the deprecated method.

@mergify
Copy link
Copy Markdown

mergify bot commented Jan 6, 2026

Documentation preview: https://vllm--31780.org.readthedocs.build/en/31780/

@mergify mergify bot added documentation Improvements or additions to documentation performance Performance-related issues labels Jan 6, 2026
Copy link
Copy Markdown
Member

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your support of the plugin dev experience! LOL!

@DarkLight1337 DarkLight1337 merged commit db31832 into vllm-project:main Jan 6, 2026
46 of 47 checks passed
@DarkLight1337 DarkLight1337 deleted the deprecate-seed-anything branch January 6, 2026 11:29
LucasWilkinson pushed a commit to neuralmagic/vllm that referenced this pull request Jan 6, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation performance Performance-related issues ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants