Skip to content

[CI] Fix CPU MM Processor Test#31764

Merged
DarkLight1337 merged 4 commits intomainfrom
fix-mm-processor-cpu
Jan 6, 2026
Merged

[CI] Fix CPU MM Processor Test#31764
DarkLight1337 merged 4 commits intomainfrom
fix-mm-processor-cpu

Conversation

@robertgshaw2-redhat
Copy link
Copy Markdown
Collaborator

@robertgshaw2-redhat robertgshaw2-redhat commented Jan 6, 2026

Purpose

  • in cpu ci, we end up with timm==1.0.23, which is incompatible
  • in follow ups, we should not pip compile in the cpu docker

Test Plan

  • ci

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Robert Shaw <robshaw@redhat.com>
@robertgshaw2-redhat robertgshaw2-redhat changed the title add fixed dependency [CI] Fix CPU MM PRocessor Test Jan 6, 2026
@robertgshaw2-redhat robertgshaw2-redhat marked this pull request as ready for review January 6, 2026 02:33
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a pinned dependency for timm to requirements/test.in to resolve a CI issue. However, this introduces a redundant dependency specification, as timm is already listed. This redundancy can cause issues with dependency resolution and should be addressed by consolidating the requirements into a single, correct entry.

datamodel_code_generator # required for minicpm3 test
lm-eval[api]>=0.4.9.2 # required for model evaluation test
mteb[bm25s]>=2, <3 # required for mteb test
timm==1.0.17 # in cpu ci, this can get set to newer, incompatible version
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This line introduces a redundant dependency specification for timm. The file already contains timm >=1.0.17 on line 27. Having two conflicting or redundant specifications for the same package can lead to unpredictable dependency resolution and should be avoided.

To fix the incompatibility issue noted in your comment, please modify the existing requirement on line 27 to timm==1.0.17 and remove this new line.

Robert Shaw added 2 commits January 5, 2026 21:37
Signed-off-by: Robert Shaw <robshaw@redhat.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 6, 2026 03:16
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 6, 2026
@robertgshaw2-redhat
Copy link
Copy Markdown
Collaborator Author

unblocked the MM processor test to check

@robertgshaw2-redhat robertgshaw2-redhat changed the title [CI] Fix CPU MM PRocessor Test [CI] Fix CPU MM Processor Test Jan 6, 2026
@DarkLight1337 DarkLight1337 merged commit 81323ea into main Jan 6, 2026
22 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-mm-processor-cpu branch January 6, 2026 04:22
@DarkLight1337 DarkLight1337 mentioned this pull request Jan 6, 2026
5 tasks
LucasWilkinson pushed a commit to neuralmagic/vllm that referenced this pull request Jan 6, 2026
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Co-authored-by: Robert Shaw <robshaw@redhat.com>
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Co-authored-by: Robert Shaw <robshaw@redhat.com>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Co-authored-by: Robert Shaw <robshaw@redhat.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Co-authored-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Robert Shaw <robshaw@redhat.com>
Co-authored-by: Robert Shaw <robshaw@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants