Conversation
Signed-off-by: Robert Shaw <robshaw@redhat.com>
There was a problem hiding this comment.
Code Review
This pull request adds a pinned dependency for timm to requirements/test.in to resolve a CI issue. However, this introduces a redundant dependency specification, as timm is already listed. This redundancy can cause issues with dependency resolution and should be addressed by consolidating the requirements into a single, correct entry.
requirements/test.in
Outdated
| datamodel_code_generator # required for minicpm3 test | ||
| lm-eval[api]>=0.4.9.2 # required for model evaluation test | ||
| mteb[bm25s]>=2, <3 # required for mteb test | ||
| timm==1.0.17 # in cpu ci, this can get set to newer, incompatible version |
There was a problem hiding this comment.
This line introduces a redundant dependency specification for timm. The file already contains timm >=1.0.17 on line 27. Having two conflicting or redundant specifications for the same package can lead to unpredictable dependency resolution and should be avoided.
To fix the incompatibility issue noted in your comment, please modify the existing requirement on line 27 to timm==1.0.17 and remove this new line.
…t/vllm into fix-mm-processor-cpu
|
unblocked the MM processor test to check |
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
Signed-off-by: Robert Shaw <robshaw@redhat.com> Co-authored-by: Robert Shaw <robshaw@redhat.com>
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.