Skip to content

Fix ijson build for Power.#31702

Merged
bigPYJ1151 merged 5 commits intovllm-project:mainfrom
odh-on-pz:fix-ijson-build
Jan 8, 2026
Merged

Fix ijson build for Power.#31702
bigPYJ1151 merged 5 commits intovllm-project:mainfrom
odh-on-pz:fix-ijson-build

Conversation

@npanpaliya
Copy link
Copy Markdown
Contributor

@npanpaliya npanpaliya commented Jan 5, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@mergify mergify bot added the ci/build label Jan 5, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the ijson build for PowerPC by updating CentOS stream repository packages and adding yajl-devel. While the changes are mostly correct, there is a critical issue in the Dockerfile where an incorrect version of a package is being removed. This could lead to build failures or an unclean image. I've provided a specific comment with a suggested fix to address this.

@bigPYJ1151 bigPYJ1151 enabled auto-merge (squash) January 8, 2026 02:07
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 8, 2026
@bigPYJ1151 bigPYJ1151 disabled auto-merge January 8, 2026 02:08
@bigPYJ1151
Copy link
Copy Markdown
Member

Hi @npanpaliya looks like you need to rebase this to the latest main.

@bigPYJ1151 bigPYJ1151 removed the ready ONLY add when PR is ready to merge/full CI is needed label Jan 8, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
@npanpaliya
Copy link
Copy Markdown
Contributor Author

Thanks @bigPYJ1151 - I've rebased my branch.

@bigPYJ1151 bigPYJ1151 enabled auto-merge (squash) January 8, 2026 16:35
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 8, 2026
@bigPYJ1151 bigPYJ1151 merged commit a563866 into vllm-project:main Jan 8, 2026
17 checks passed
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants