Fix ijson build for Power.#31702
Merged
bigPYJ1151 merged 5 commits intovllm-project:mainfrom Jan 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix the ijson build for PowerPC by updating CentOS stream repository packages and adding yajl-devel. While the changes are mostly correct, there is a critical issue in the Dockerfile where an incorrect version of a package is being removed. This could lead to build failures or an unclean image. I've provided a specific comment with a suggested fix to address this.
0e3b99b to
19883d0
Compare
bigPYJ1151
approved these changes
Jan 8, 2026
Member
|
Hi @npanpaliya looks like you need to rebase this to the latest main. |
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
19883d0 to
0eb7ab4
Compare
Contributor
Author
|
Thanks @bigPYJ1151 - I've rebased my branch. |
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Nishidha Panpaliya <nishidha.panpaliya@partner.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.