Skip to content

[Bugfix] Fix AttributeError: 'Stream' object has no attribute 'dp_size'#31663

Merged
DarkLight1337 merged 3 commits intovllm-project:mainfrom
jeejeelee:fix-lora-bug
Jan 5, 2026
Merged

[Bugfix] Fix AttributeError: 'Stream' object has no attribute 'dp_size'#31663
DarkLight1337 merged 3 commits intovllm-project:mainfrom
jeejeelee:fix-lora-bug

Conversation

@jeejeelee
Copy link
Copy Markdown
Collaborator

@jeejeelee jeejeelee commented Jan 4, 2026

Purpose

#31533 deleted the shared_experts_stream attribute in FusedMoEModularKernel, which led to LoRA MoE initialization failure.

(EngineCore_DP0 pid=1301291)   File "/vllm/vllm/model_executor/layers/fused_moe/modular_kernel.py", line 698, in __init__
(EngineCore_DP0 pid=1301291)     and moe_parallel_config.dp_size > 1
(EngineCore_DP0 pid=1301291)         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
(EngineCore_DP0 pid=1301291) AttributeError: 'Stream' object has no attribute 'dp_size'

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 4, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request removes the shared_experts_stream argument from a function call within the _inject_lora_into_fused_moe method in vllm/lora/layers/fused_moe.py.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 4, 2026 08:14
@DarkLight1337 DarkLight1337 merged commit f099cd5 into vllm-project:main Jan 5, 2026
49 checks passed
@jeejeelee jeejeelee deleted the fix-lora-bug branch January 5, 2026 06:03
LucasWilkinson pushed a commit to neuralmagic/vllm that referenced this pull request Jan 6, 2026
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…e' (vllm-project#31663)

Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants