Skip to content

Fix: Add None check in step_with_batch_queue for async scheduling #31600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ricky-chaoju wants to merge 1 commit into from
Closed

Fix: Add None check in step_with_batch_queue for async scheduling #31600

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions vllm/v1/engine/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,11 @@ def step_with_batch_queue(
with self.log_error_detail(scheduler_output):
model_output = future.result()

# Handle None return from execute_model (async scheduling)
if model_output is None:
grammar_output = self.scheduler.get_grammar_bitmask(scheduler_output)
model_output = self.model_executor.sample_tokens(grammar_output)

# Before processing the model output, process any aborts that happened
# during the model execution.
self._process_aborts_queue()
Expand Down