[Bugfix] Replace BaseException with specific exceptions in FLA utils

[c0de128]

Summary

Change except BaseException: to except (RuntimeError, AttributeError): in get_available_device() function.

Details

BaseException catches SystemExit, KeyboardInterrupt, and GeneratorExit which should propagate normally. The triton driver access can raise:

• RuntimeError: If triton backend is not available
• AttributeError: If driver/target attributes don't exist

This prevents masking critical system exceptions during device detection.

Test plan

• Code review confirms change is safe
• Existing tests pass
• Hardware verification (will post results)

🤖 Generated with Claude Code

[gemini-code-assist]

Code Review

This pull request correctly replaces a broad except BaseException: with the more specific except (RuntimeError, AttributeError): in the get_available_device function. This is a crucial improvement for robustness, as it prevents the accidental suppression of system-level exceptions like SystemExit and KeyboardInterrupt. The change is well-targeted and follows best practices for exception handling. The implementation is correct.

[njhill]

Thanks @co63oc

[c0de128]

Hardware Verification (MI300X VF)

Verified the BaseException fix on MI300X:

# Branch verified
git checkout fix/fla-utils-baseexception
# Commit: 6869c459b [Bugfix] Replace BaseException with specific exceptions in FLA utils

# Fix confirmed in place
grep -n 'except (RuntimeError, AttributeError)' vllm/model_executor/layers/fla/ops/utils.py
122:    except (RuntimeError, AttributeError):

# Module loads correctly
>>> from vllm.model_executor.layers.fla.ops.utils import get_available_device, device_platform
>>> get_available_device()
'hip'
>>> device_platform
'amd'

Test environment:

• GPU: AMD Instinct MI300X VF (192GB)
• vLLM: 0.7.4.dev (Docker rocm/vllm-dev:main)
• ROCm: 6.3

FLA utils import and device detection working correctly with the fix.