[Misc][BE] Type coverage for vllm/compilation [1/3]

[Lucaskabela]

Purpose

We want to provide better type hint coverage in vllm/compilation to improve maintainability, readability, and reduce silent errors

Test Plan

mypy vllm/compilation

---

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
• (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

[gemini-code-assist]

Code Review

This pull request significantly improves the type coverage for the vllm/compilation module. The added type hints are accurate and comprehensive, covering function signatures, variables, and return types, which will enhance code maintainability, readability, and help prevent silent errors. The use of more specific types like Generator, Literal, ParamSpec, and TypeVar is particularly noteworthy. Additionally, a crucial assertion was added to prevent a potential runtime TypeError, further improving the code's robustness. The changes are well-executed and represent a valuable improvement to the codebase.

[mergify]

Hi @Lucaskabela, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?

mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:

# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

[zou3519]

why does this need a cast to bool?

[Lucaskabela]

vLLM type checking is in a kind of weird mode - the follow_imports currently is set for pre-commit (locally), which for the case of some torch functions, means they are stubbed as Any types. This raises an error mismatch (returning Any when declared type bool), so an explicit cast makes the linter happy here

[hmellor]

For all the directories in

https://github.com/vllm-project/vllm/blob/3c3c547ce0b35fb9d43808e8609f5e86fc34cca1/tools/pre_commit/mypy.py#L26C1-L54

follow imports has its default value for mypy. Note that vllm/compilation is not included in this list.

For all the directories in

vllm/tools/pre_commit/mypy.py

Lines 58 to 67 in 3c3c547

	SEPARATE_GROUPS = [
	"tests",
	# v0 related
	"vllm/compilation",
	"vllm/lora",
	"vllm/model_executor",
	# v1 related
	"vllm/v1/kv_offload",
	"vllm/v1/spec_decode",
	]

mypy is run separately with --follow-imports skip.

Once all the import following related issues have been fixed for a directory in SEPARATE_GROUPS, it should be moved to FILES.