[Docs] Fix some snippets#31378
Merged
DarkLight1337 merged 1 commit intovllm-project:mainfrom Dec 26, 2025
Merged
Conversation
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Documentation preview: https://vllm--31378.org.readthedocs.build/en/31378/ |
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses several issues with the documentation generation process. It corrects the output directory for argparse documentation, updates the file extension for generated metrics files to .inc.md, and modifies all relevant markdown files to include snippets from the correct paths. The changes are consistent and effectively fix the broken documentation links. The code modifications are correct and well-contained.
DarkLight1337
approved these changes
Dec 26, 2025
patrickvonplaten
pushed a commit
to patrickvonplaten/vllm
that referenced
this pull request
Dec 27, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: Patrick von Platen <patrick.v.platen@gmail.com>
yiliu30
pushed a commit
to yiliu30/vllm-fork
that referenced
this pull request
Dec 30, 2025
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.mdfiles (which don't exist) where they should have been.inc.mdfilesgenerate_metrics.pyto use.inc.mdgenerate_argparse.pyto use thedocs/generated/argparseoutput dir