[Mics] add pcp basic support to MoE model#31003
Merged
simon-mo merged 3 commits intovllm-project:mainfrom Dec 31, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug by adding basic support for Prefill Context Parallelism (PCP) to the MoE model configuration. It introduces pcp_size and pcp_rank properties to the FusedMoEConfig class, which were missed in a previous pull request. The implementation correctly delegates to the moe_parallel_config and is consistent with existing properties for other parallelism types. The changes are correct and necessary for full PCP feature support in MoE models.
|
Hi @pisceskkk, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com>
e0217d8 to
2e3c78e
Compare
mgoin
approved these changes
Dec 31, 2025
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Jan 9, 2026
akh64bit
pushed a commit
to akh64bit/vllm
that referenced
this pull request
Jan 16, 2026
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add the modifications missed in the PR #28718 for basic PCP feature support.
CC @LucasWilkinson @FENP @LookAround0301