Skip to content

[Mics] add pcp basic support to MoE model#31003

Merged
simon-mo merged 3 commits intovllm-project:mainfrom
pisceskkk:pcp_bugfix
Dec 31, 2025
Merged

[Mics] add pcp basic support to MoE model#31003
simon-mo merged 3 commits intovllm-project:mainfrom
pisceskkk:pcp_bugfix

Conversation

@pisceskkk
Copy link
Copy Markdown
Contributor

@pisceskkk pisceskkk commented Dec 19, 2025

Purpose

Add the modifications missed in the PR #28718 for basic PCP feature support.

CC @LucasWilkinson @FENP @LookAround0301

@pisceskkk pisceskkk changed the title [bugfix] add pcp basic support to MoE model [Mics] add pcp basic support to MoE model Dec 19, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a bug by adding basic support for Prefill Context Parallelism (PCP) to the MoE model configuration. It introduces pcp_size and pcp_rank properties to the FusedMoEConfig class, which were missed in a previous pull request. The implementation correctly delegates to the moe_parallel_config and is consistent with existing properties for other parallelism types. The changes are correct and necessary for full PCP feature support in MoE models.

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 19, 2025

Hi @pisceskkk, the pre-commit checks have failed. Please run:

uv pip install pre-commit
pre-commit install
pre-commit run --all-files

Then, commit the changes and push to your branch.

For future commits, pre-commit will run automatically on changed files before each commit.

Tip

Is mypy or markdownlint failing?
mypy and markdownlint are run differently in CI. If the failure is related to either of these checks, please use the following commands to run them locally:
# For mypy (substitute "3.10" with the failing version if needed)
pre-commit run --hook-stage manual mypy-3.10
# For markdownlint
pre-commit run --hook-stage manual markdownlint

Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com>
Copy link
Copy Markdown
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LucasWilkinson LucasWilkinson enabled auto-merge (squash) December 28, 2025 17:23
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 28, 2025
@simon-mo simon-mo merged commit 84f6cd7 into vllm-project:main Dec 31, 2025
49 of 51 checks passed
@pisceskkk pisceskkk deleted the pcp_bugfix branch December 31, 2025 06:10
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants