Skip to content

[Misc] Remove deprecated metric vllm:time_per_output_token_seconds for v0.13 release #30992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jliu9515 wants to merge 1 commit into from
Closed

[Misc] Remove deprecated metric vllm:time_per_output_token_seconds for v0.13 release #30992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 0 additions & 39 deletions vllm/v1/metrics/loggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,43 +715,6 @@ def __init__(
histogram_time_to_first_token, engine_indexes, model_name
)

# Deprecated in 0.11 - Renamed as vllm:inter_token_latency_seconds
# With 0.12.x you can enable with --show-hidden-metrics-for-version=0.11
# TODO: remove in 0.13.0
if self.show_hidden_metrics:
histogram_time_per_output_token = self._histogram_cls(
name="vllm:time_per_output_token_seconds",
documentation=(
"Histogram of time per output token in seconds."
"DEPRECATED: Use vllm:inter_token_latency_seconds instead."
),
buckets=[
0.01,
0.025,
0.05,
0.075,
0.1,
0.15,
0.2,
0.3,
0.4,
0.5,
0.75,
1.0,
2.5,
5.0,
7.5,
10.0,
20.0,
40.0,
80.0,
],
labelnames=labelnames,
)
self.histogram_time_per_output_token = make_per_engine(
histogram_time_per_output_token, engine_indexes, model_name
)

histogram_inter_token_latency = self._histogram_cls(
name="vllm:inter_token_latency_seconds",
documentation="Histogram of inter-token latency in seconds.",
Comment on lines 715 to 720
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Remove hidden metric but keep tests expecting it

This block used to build vllm:time_per_output_token_seconds when --show-hidden-metrics-for-version was enabled; with the removal, the metric is no longer exported even when show_hidden_metrics is true. tests/entrypoints/instrumentator/test_metrics.py still lists vllm:time_per_output_token_seconds_* in HIDDEN_DEPRECATED_METRICS and asserts they appear when the server is started with the hidden-metrics flag, so those test cases (and any users still relying on the migration flag for that alias) now fail because the metric is absent. Please drop the expectation or leave the metric available under the flag.

Useful? React with 👍 / 👎.

Expand Down Expand Up @@ -1124,8 +1087,6 @@ def record(
self.histogram_time_to_first_token[engine_idx].observe(ttft)
for itl in iteration_stats.inter_token_latencies_iter:
self.histogram_inter_token_latency[engine_idx].observe(itl)
if self.show_hidden_metrics:
self.histogram_time_per_output_token[engine_idx].observe(itl)

for finished_request in iteration_stats.finished_requests:
self.counter_request_success[finished_request.finish_reason][
Expand Down