[Bugfix] Fix Unicode issues in GLM-4 tool calling#30920
Merged
youkaichao merged 1 commit intovllm-project:mainfrom Dec 18, 2025
Merged
[Bugfix] Fix Unicode issues in GLM-4 tool calling#30920youkaichao merged 1 commit intovllm-project:mainfrom
youkaichao merged 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the GLM-4 tool parser where Unicode characters in tool call arguments were not being handled correctly by adding ensure_ascii=False to the json.dumps call. This prevents non-ASCII characters from being escaped. I have added one comment to further improve the robustness of the JSON serialization to prevent potential silent failures when encountering non-serializable data types.
youkaichao
approved these changes
Dec 18, 2025
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Dec 22, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
bbrowning
added a commit
to bbrowning/vllm
that referenced
this pull request
Mar 26, 2026
Audited recent tool parser bug-fix PRs and found that several landed without corresponding test coverage. Added unit tests for each fix to prevent regressions. - Mistral: fast detokenization text detection (PR vllm-project#37209) - Qwen3Coder: malformed XML crash, anyOf double-encoding, speculative decode streaming (PRs vllm-project#36774, vllm-project#36032, vllm-project#35615) - DeepSeekV32: delimiter preservation with fast detokenization, skip_special_tokens adjustment (PR vllm-project#33964) - GLM-4 MoE: zero-argument tool calls, transformers 5.x delimiter handling, Unicode character preservation (PRs vllm-project#32321, vllm-project#31622, vllm-project#30920) - MiniMax M2: anyOf nullable parameter handling for non-null and null values (PR vllm-project#32342) - Step3p5: MTP-style variable-chunk and multi-token streaming (PR vllm-project#33690) - Kimi K2: native tool call ID extraction and multi-turn ID continuity (PR vllm-project#32768) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ben Browning <bbrownin@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Test Plan
main
this pr
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.