[Refactor] Refactor for DeepGemmQuantScaleFMT using cache#30898
Merged
Conversation
Signed-off-by: yewentao256 <zhyanwentao@126.com>
yewentao256
requested review from
mgoin,
pavanimajety,
robertgshaw2-redhat and
tlrmchlsmth
as code owners
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
yewentao256
changed the title
DeepGemmQuantScaleFMTDeepGemmQuantScaleFMT using cache
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the DeepGemmQuantScaleFMT logic to be torch.compile friendly by introducing a caching mechanism. The changes are well-structured and improve maintainability by centralizing the logic.
However, I've found a critical issue of infinite recursion in the new implementation of init_oracle_cache. Please see my comment for details and a suggested fix. There is also a minor typo in the pull request title ('Refactpr').
mgoin
approved these changes
Dec 19, 2025
yugong333
pushed a commit
to yugong333/vllm
that referenced
this pull request
Dec 22, 2025
…ject#30898) Signed-off-by: yewentao256 <zhyanwentao@126.com>
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…ject#30898) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…ject#30898) Signed-off-by: yewentao256 <zhyanwentao@126.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…ject#30898) Signed-off-by: yewentao256 <zhyanwentao@126.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
A follow up PR for #30336 (comment)
DeepGemmQuantScaleFMTinstead ofif self.use_deep_gemm_e8m0 and self.is_blackwell:DeepGemmQuantScaleFMTusing cache so that we won't havetorch._dynamo.exc.Unsupported: can't handle functions not implemented in pythonin the future