Skip to content

[Fix] pass chat_template_kwargs to get_system_message in gpt-oss #30873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seunggil1 wants to merge 4 commits into from
Closed

[Fix] pass chat_template_kwargs to get_system_message in gpt-oss #30873

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f431f4
[Fix] pass chat_template_kwargs to get_system_message in gpt-oss
seunggil1 Dec 17, 2025
a03caeb
fix : TypeError when passing chat_template_kwargs to get_system_message
seunggil1 Dec 17, 2025
bdcd953
[refactor] apply pre-commit
seunggil1 Dec 17, 2025
672edf3
Merge branch 'main' into fix/gpt-oss-model-identity
seunggil1 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions vllm/entrypoints/openai/serving_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1796,11 +1796,25 @@ def _make_request_with_harmony(
# if the model supports it. TODO: Support browsing.
assert not self.supports_browsing
assert not self.supports_code_interpreter
sys_msg_kwargs = {
"reasoning_effort": request.reasoning_effort,
"browser_description": None,
"python_description": None,
"with_custom_tools": request.tools is not None,
**(request.chat_template_kwargs or {}),
}
allowed_keys = {
"model_identity",
"reasoning_effort",
"start_date",
"browser_description",
"python_description",
"container_description",
"instructions",
"with_custom_tools",
}
sys_msg = get_system_message(
reasoning_effort=request.reasoning_effort,
browser_description=None,
python_description=None,
with_custom_tools=request.tools is not None,
**{k: v for k, v in sys_msg_kwargs.items() if k in allowed_keys}
)
messages.append(sys_msg)

Expand Down