[Doc] Show that use_audio_in_video is supported in docs#30837
[Doc] Show that use_audio_in_video is supported in docs#30837vllm-bot merged 2 commits intovllm-project:mainfrom
use_audio_in_video is supported in docs#30837Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Documentation preview: https://vllm--30837.org.readthedocs.build/en/30837/ |
There was a problem hiding this comment.
Code Review
This pull request aims to update the documentation to indicate that use_audio_in_video is now supported for Qwen2.5-Omni and Qwen3-Omni models. While this might be true for the V2 engine, the changes are misleading as the codebase contains explicit TODO comments indicating that this feature is not yet supported on the V1 engine due to lack of support for interleaved modalities. I've left two critical comments suggesting to either restore the notes or update them to clarify that the feature is only available on the V2 engine. This will prevent confusion for users who are on the V1 engine.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
17e6dc7 to
44316ba
Compare
…ct#30837) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…ct#30837) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…ct#30837) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…ct#30837) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
…ct#30837) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Purpose
Address #30779 (comment) now that #27721 has been merged
Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.