Skip to content

[Doc] Show that use_audio_in_video is supported in docs#30837

Merged
vllm-bot merged 2 commits intovllm-project:mainfrom
DarkLight1337:doc-audio-in-video
Jan 6, 2026
Merged

[Doc] Show that use_audio_in_video is supported in docs#30837
vllm-bot merged 2 commits intovllm-project:mainfrom
DarkLight1337:doc-audio-in-video

Conversation

@DarkLight1337
Copy link
Copy Markdown
Member

@DarkLight1337 DarkLight1337 commented Dec 17, 2025

Purpose

Address #30779 (comment) now that #27721 has been merged

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 17, 2025
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.

@mergify
Copy link
Copy Markdown

mergify bot commented Dec 17, 2025

Documentation preview: https://vllm--30837.org.readthedocs.build/en/30837/

@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 17, 2025
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update the documentation to indicate that use_audio_in_video is now supported for Qwen2.5-Omni and Qwen3-Omni models. While this might be true for the V2 engine, the changes are misleading as the codebase contains explicit TODO comments indicating that this feature is not yet supported on the V1 engine due to lack of support for interleaved modalities. I've left two critical comments suggesting to either restore the notes or update them to clarify that the feature is only available on the V2 engine. This will prevent confusion for users who are on the V1 engine.

@mergify mergify bot added the qwen Related to Qwen models label Dec 17, 2025
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@Isotr0py Isotr0py enabled auto-merge (squash) January 6, 2026 07:16
@vllm-bot vllm-bot merged commit da71d44 into vllm-project:main Jan 6, 2026
15 of 40 checks passed
@DarkLight1337 DarkLight1337 deleted the doc-audio-in-video branch January 6, 2026 07:27
LucasWilkinson pushed a commit to neuralmagic/vllm that referenced this pull request Jan 6, 2026
…ct#30837)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
yugong333 pushed a commit to yugong333/vllm that referenced this pull request Jan 9, 2026
…ct#30837)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
akh64bit pushed a commit to akh64bit/vllm that referenced this pull request Jan 16, 2026
…ct#30837)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
dsuhinin pushed a commit to dsuhinin/vllm that referenced this pull request Jan 21, 2026
…ct#30837)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX pushed a commit to ItzDEXX/vllm that referenced this pull request Feb 19, 2026
…ct#30837)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation qwen Related to Qwen models ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants