[Refactor][TPU] Remove torch_xla path and use tpu-inference#30808
[Refactor][TPU] Remove torch_xla path and use tpu-inference#30808DarkLight1337 merged 13 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
This pull request has merge conflicts that must be resolved before it can be |
There was a problem hiding this comment.
Code Review
This pull request is a significant refactoring that removes the deprecated torch_xla based TPU backend. The changes are extensive, involving the deletion of numerous files and code blocks related to the old TPU implementation, including tests, model runners, workers, and various utility functions. The new approach mandates the use of the tpu-inference package for TPU support, and the codebase now reflects this by either importing from tpu-inference or failing with a clear error message if the package is not installed. The code removal appears to be clean and thorough, and the new dependency model is explicit and well-defined. The changes are consistent with the stated purpose of the pull request and represent a solid step forward in simplifying the TPU backend support.
|
Documentation preview: https://vllm--30808.org.readthedocs.build/en/30808/ |
7f4717f to
f21f5ea
Compare
99193f9 to
57a924e
Compare
|
Hi @weiyu0824, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
907769b to
c2c433a
Compare
|
Hi @weiyu0824, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
c2c433a to
48755c1
Compare
|
Hi @weiyu0824, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
0539c87 to
edb6b94
Compare
|
This pull request has merge conflicts that must be resolved before it can be |
edb6b94 to
373a222
Compare
|
Affected by #31044 (comment) |
|
This pull request has merge conflicts that must be resolved before it can be |
|
Hi @weiyu0824, the pre-commit checks have failed. Please run: uv pip install pre-commit
pre-commit install
pre-commit run --all-filesThen, commit the changes and push to your branch. For future commits, Tip Is
|
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
…mplementation Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
Signed-off-by: Wei-Yu Lin <weiyulin@google.com>
|
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: weiyu <62784299+weiyu0824@users.noreply.github.com>
Purpose
Removes torch_xla related code paths as this backend is now deprecated. To run vLLM on TPU, users should now install and use tpu-inference.
Test Plan
Test Result
What has been removed
Pending Removal