[Docs][API] Remove warning about LoRARequest being internal-only#30774
Merged
vllm-bot merged 1 commit intovllm-project:mainfrom Dec 16, 2025
Merged
[Docs][API] Remove warning about LoRARequest being internal-only#30774vllm-bot merged 1 commit intovllm-project:mainfrom
vllm-bot merged 1 commit intovllm-project:mainfrom
Conversation
Since `LoRARequest` is part of the public API - e.g. as a parameter to `LLM.generate()` or since vllm-project#30636 a member of `RequestOutput` - this warning looks outdated: ```python class LoRARequest(...): """ Request for a LoRA adapter. Note that this class should be used internally. For online serving, it is recommended to not allow users to use this class but instead provide another layer of abstraction to prevent users from accessing unauthorized LoRA adapters. ... """ ``` Indeed, `LoRAReqest` seems to have been part of the public API since it was added in vllm-project#1804 Signed-off-by: Mark McLoughlin <markmc@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes an outdated warning from the LoRARequest class docstring. The warning indicated that the class was for internal use, which is no longer accurate as it is part of the public API. The change is correct and improves the documentation's accuracy. I have no further comments.
jeejeelee
approved these changes
Dec 16, 2025
github-actions
bot
added
the
ready
Majid-Taheri
pushed a commit
to Majid-Taheri/vllm
that referenced
this pull request
Dec 23, 2025
…m-project#30774) Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: Ubuntu <mjtaheri68@gmail.com>
dsuhinin
pushed a commit
to dsuhinin/vllm
that referenced
this pull request
Jan 21, 2026
…m-project#30774) Signed-off-by: Mark McLoughlin <markmc@redhat.com> Signed-off-by: dsuhinin <suhinin.dmitriy@gmail.com>
ItzDEXX
pushed a commit
to ItzDEXX/vllm
that referenced
this pull request
Feb 19, 2026
…m-project#30774) Signed-off-by: Mark McLoughlin <markmc@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
LoRARequestis part of the public API - e.g. as a parameter toLLM.generate()or since #30636 a member ofRequestOutput- this warning looks outdated:Indeed,
LoRAReqestseems to have been part of the public API since it was added in #1804