-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[BugFix][Hybrid] Fix prefill chunk incorrectly including draft tokens #30618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
peakcrosser7
wants to merge
7
commits into
vllm-project:main
from
peakcrosser7:fix/prefill_exclude_draft
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5635e0a
[BugFix] Fix prefill chunk incorrectly including draft tokens
peakcrosser7 3f3ebcb
refactor for improved clarity
peakcrosser7 2d1275f
update the code format
peakcrosser7 c353a22
Merge branch 'main' into fix/prefill_exclude_draft
peakcrosser7 4ed21dd
Merge branch 'main' into fix/prefill_exclude_draft
peakcrosser7 5fc5f42
Merge branch 'main' into fix/prefill_exclude_draft
peakcrosser7 92aa3c7
limit fix to mamba-only
peakcrosser7 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess resume requests don't have speculative tokens so are not affected by this bug. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not sure about that. For a resumed request, couldn't extra spec tokens (e.g., gamma=3) still be appended during prefill? For example, if 1024 prompt tokens + 1024 generated tokens are resumed, calculating 2048+3 tokens in prefill phase instead of just 2048 tokens would likely lead to an incorrect Mamba state.